[GitHub] [thrift] MikaelSmith commented on a diff in pull request #2620: THRIFT-5595: Avoid peek request with SSLSocket

[GitBox <gi...@apache.org>]

MikaelSmith commented on code in PR #2620:
URL: https://github.com/apache/thrift/pull/2620#discussion_r893687599


##########
lib/py/src/transport/TSSLSocket.py:
##########
@@ -266,6 +266,10 @@ def __init__(self, host='localhost', port=9090, *args, **kwargs):
         TSocket.TSocket.__init__(self, host, port, unix_socket,
                                  socket_keepalive=socket_keepalive)
 
+    # Override TSocket because ssl.SSLSocket does not allow non-zero flags in calls to recv()
+    def isOpen(self):
+        return self.handle is not None

Review Comment:
   I guess that makes some sense in that we'd largely expect the implementations to be in-sync.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org