You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/10 13:30:01 UTC
[jira] [Commented] (CB-13744) Handle storyboards as XML files
[ https://issues.apache.org/jira/browse/CB-13744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320233#comment-16320233 ]
ASF GitHub Bot commented on CB-13744:
-------------------------------------
codecov-io commented on issue #12: CB-13744 Recognize storyboards as XML files
URL: https://github.com/apache/cordova-common/pull/12#issuecomment-356354279
# [Codecov](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=h1) Report
> Merging [#12](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-common/commit/fe21952b492dd9f90b7de07c256064626cdb8d5b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 19 19
Lines 1767 1767
Branches 376 376
=======================================
Hits 1506 1506
Misses 261 261
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/12/diff?src=pr&el=tree#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==) | `89.05% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=footer). Last update [fe21952...a2cac7e](https://codecov.io/gh/apache/cordova-common/pull/12?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Handle storyboards as XML files
> -------------------------------
>
> Key: CB-13744
> URL: https://issues.apache.org/jira/browse/CB-13744
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-common
> Reporter: Jacques Caron
> Priority: Minor
>
> When editing a file with <config-file> or <edit-config>, only a few extensions are recognised as XML, the rest are considered plists.
> The CDVLaunchScreen.storyboard generated by cordova-ios is XML. To be able to edit it from config.xml, .storyboard files need to be recognised as XML.
> Pull request: https://github.com/apache/cordova-common/pull/12
> It may make sense to take this further, and either:
> - reverse the test, and only consider .plist files to be plists, and the rest XML. Not sure if that could break something
> - or add an attribute to <config-file> and <edit-config> to specify the type of file (XML or plist).
> However for the purposes of modifying the storyboard the (very minor) change in the pull request is enough.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org