You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/26 03:56:52 UTC
[GitHub] [cordova-plugin-splashscreen] erisu opened a new pull request #277: breaking: replace jshint with eslint
erisu opened a new pull request #277:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/277
### Motivation, Context & Description
* Replace jshint with Cordova's ESLint package
* Remove any jshint references & config files
* Run and applied auto corrections from ESLint
**Note:** This PR also contains #276 changes. PR #276 should be reviewed and merged first.
### Testing
* See CI Service's Results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] timbru31 commented on pull request #277: breaking: replace jshint with eslint
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #277:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/277#issuecomment-650113643
Part of https://github.com/apache/cordova/issues/142, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a change in pull request #277: breaking: replace jshint with eslint
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #277:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/277#discussion_r446087784
##########
File path: www/windows/SplashScreenProxy.js
##########
@@ -19,7 +19,7 @@
*
*/
-/*jslint sloppy:true */
+/* jslint sloppy:true */
Review comment:
:D I thought I delete all these
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu merged pull request #277: breaking: replace jshint with eslint
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #277:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] timbru31 commented on a change in pull request #277: breaking: replace jshint with eslint
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #277:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/277#discussion_r446083533
##########
File path: www/windows/SplashScreenProxy.js
##########
@@ -19,7 +19,7 @@
*
*/
-/*jslint sloppy:true */
+/* jslint sloppy:true */
Review comment:
remove ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org