You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pixelherodev (via GitHub)" <gi...@apache.org> on 2025/11/07 14:36:44 UTC

[PR] optimization: schema: use slices.Sort instead of sort.Slice [arrow-go]

pixelherodev opened a new pull request, #564:
URL: https://github.com/apache/arrow-go/pull/564

   Shaves off nearly half of the time of Metadata.Equal for me; sort.Slice takes in `any` as the type of the slice, which requires converting the slice to an interface - which itself requires allocating and converting the pointer to the slice header to use as the interface value.
   
   ### Rationale for this change
   
   
   ### What changes are included in this PR?
   
   
   ### Are these changes tested?
   
   
   ### Are there any user-facing changes?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] optimization: schema: use slices.Sort instead of sort.Slice [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #564:
URL: https://github.com/apache/arrow-go/pull/564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] optimization: schema: use slices.Sort instead of sort.Slice [arrow-go]

Posted by "pixelherodev (via GitHub)" <gi...@apache.org>.
pixelherodev commented on PR #564:
URL: https://github.com/apache/arrow-go/pull/564#issuecomment-3502937126

   sort.Strings is just a wrapper for slices.Sort now; as such, drop the other usage of the sort module in schema.go and drop the dependency too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] optimization: schema: use slices.Sort instead of sort.Slice [arrow-go]

Posted by "pixelherodev (via GitHub)" <gi...@apache.org>.
pixelherodev commented on PR #564:
URL: https://github.com/apache/arrow-go/pull/564#issuecomment-3518812230

   I figure I should probably include this as the motivation:
   
   <img width="3840" height="343" alt="image" src="https://github.com/user-attachments/assets/c6225e86-bfe4-4371-9a02-a01c4f284785" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org