[GitHub] [tvm] leandron commented on a change in pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#discussion_r586291160



##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
 export PYXIR_HOME=/opt/pyxir
 mkdir "$PYXIR_HOME"
 
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0

Review comment:
       This probably requires your tutorial to be updated as well:
   https://github.com/apache/tvm/blob/1455536cc22465cd6b7f6dde4f235c89ed4c5c3c/docs/deploy/vitis_ai.rst#L353
   
   Note: this dependency is also mentioned on the [tensorflow installation script](https://github.com/apache/tvm/blob/0dc7de512b0328d15e85ba5c49234e9993493d2d/docker/install/ubuntu_install_tensorflow.sh) as `"h5py<3.0"`, so despite the duplication I think it is OK (quick mention to @areusch in this initiative to unify python deps).

##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
 export PYXIR_HOME=/opt/pyxir
 mkdir "$PYXIR_HOME"
 
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
 
-git clone --recursive --branch v0.1.3 https://github.com/Xilinx/pyxir.git "${PYXIR_HOME}"
+git clone --recursive --branch v0.1.6 https://github.com/Xilinx/pyxir.git "${PYXIR_HOME}"

Review comment:
       Do you think it worth adding a `--depth 1` here so that you only clone the last commit in the branch?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org