[jira] [Commented] (THRIFT-3879) Undefined evaluation order

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379015#comment-15379015 ] 

ASF GitHub Bot commented on THRIFT-3879:
----------------------------------------

GitHub user dtmuller opened a pull request:

    https://github.com/apache/thrift/pull/1050

    THRIFT-3879 Undefined evaluation order

    The evaluation order of f1 and f2 in `x = f1() + f2()` is undefined...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dtmuller/thrift THRIFT-3879

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1050.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1050
    
----
commit 09a7442b85b1b3de93075a857c52379fde214d2b
Author: dtmuller <dt...@web.de>
Date:   2016-07-15T08:05:43Z

    Fix undefined evaluation order

----


> Undefined evaluation order
> --------------------------
>
>                 Key: THRIFT-3879
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3879
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>            Reporter: Daniel Mueller
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Concerns JSON protocol only: The evaluation order of the following equation is undefined:
> lib/cpp/src/thrift/protocol/TJSONProtocol.cpp:
> {{return writeJSONObjectEnd() + writeJSONArrayEnd();}}
> I will supply a fix and a merge request...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)