You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jd...@apache.org on 2005/12/07 18:40:10 UTC
svn commit: r354811 -
/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
Author: jdcasey
Date: Wed Dec 7 09:39:54 2005
New Revision: 354811
URL: http://svn.apache.org/viewcvs?rev=354811&view=rev
Log:
PR: MNG-1379
Commented out the line in EclipsePlugin.java that reconfigures the artifact file based on dependency systemPath, and reran the tests...it seems to pass just fine, so I assume the problem has been fixed as a side effect of another issue's resolution. I'm leaving the code in there (but commenting out the method call), just in case this proves to be incorrect.
Modified:
maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
Modified: maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java?rev=354811&r1=354810&r2=354811&view=diff
==============================================================================
--- maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java (original)
+++ maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java Wed Dec 7 09:39:54 2005
@@ -341,7 +341,7 @@
Collection artifacts = project.getTestArtifacts();
EclipseUtils.fixMissingOptionalArtifacts( artifacts, project.getDependencyArtifacts(), localRepository,
artifactResolver, remoteArtifactRepositories, getLog() );
- EclipseUtils.fixSystemScopeArtifacts( artifacts, project.getDependencies() );
+// EclipseUtils.fixSystemScopeArtifacts( artifacts, project.getDependencies() );
return artifacts;
}
Re: svn commit: r354811 - /maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
Posted by John Casey <jd...@yahoo.com>.
you mean 2.0, right? ...since we're about to release 2.0.1, but I think
the intention is still to maintain compat with 2.0.
Noted, though...I'll get a copy of 2.0 set aside for when I'm releasing
these...
Brett Porter wrote:
> BTW, all plugin releases should be tested with the last stable release,
> not a bootstrapped version.
>
> John Casey wrote:
>
>>fair enough. I'll roll back.
>>
>>Fabrizio Giustina wrote:
>>
>>>Hi John
>>>if you remove this, the plugin will require maven 2.0.1 in order to
>>>generate correct system dependencies. What about leaving it as is for
>>>backward compatibility?
>>>
>>>fabrizio
>>>
>>>
>>>On 12/7/05, jdcasey@apache.org <jd...@apache.org> wrote:
>>>
>>>
>>>>Author: jdcasey
>>>>Date: Wed Dec 7 09:39:54 2005
>>>>New Revision: 354811
>>>>
>>>>URL: http://svn.apache.org/viewcvs?rev=354811&view=rev
>>>>Log:
>>>>PR: MNG-1379
>>>>
>>>>Commented out the line in EclipsePlugin.java that reconfigures the
>>>>artifact file based on dependency systemPath, and reran the
>>>>tests...it seems to pass just fine, so I assume the problem has been
>>>>fixed as a side effect of another issue's resolution. I'm leaving the
>>>>code in there (but commenting out the method call), just in case this
>>>>proves to be incorrect.
>>>
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r354811 - /maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
Posted by Brett Porter <br...@apache.org>.
BTW, all plugin releases should be tested with the last stable release,
not a bootstrapped version.
John Casey wrote:
> fair enough. I'll roll back.
>
> Fabrizio Giustina wrote:
>> Hi John
>> if you remove this, the plugin will require maven 2.0.1 in order to
>> generate correct system dependencies. What about leaving it as is for
>> backward compatibility?
>>
>> fabrizio
>>
>>
>> On 12/7/05, jdcasey@apache.org <jd...@apache.org> wrote:
>>
>>> Author: jdcasey
>>> Date: Wed Dec 7 09:39:54 2005
>>> New Revision: 354811
>>>
>>> URL: http://svn.apache.org/viewcvs?rev=354811&view=rev
>>> Log:
>>> PR: MNG-1379
>>>
>>> Commented out the line in EclipsePlugin.java that reconfigures the
>>> artifact file based on dependency systemPath, and reran the
>>> tests...it seems to pass just fine, so I assume the problem has been
>>> fixed as a side effect of another issue's resolution. I'm leaving the
>>> code in there (but commenting out the method call), just in case this
>>> proves to be incorrect.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r354811 - /maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
Posted by John Casey <jd...@yahoo.com>.
fair enough. I'll roll back.
Fabrizio Giustina wrote:
> Hi John
> if you remove this, the plugin will require maven 2.0.1 in order to
> generate correct system dependencies. What about leaving it as is for
> backward compatibility?
>
> fabrizio
>
>
> On 12/7/05, jdcasey@apache.org <jd...@apache.org> wrote:
>
>>Author: jdcasey
>>Date: Wed Dec 7 09:39:54 2005
>>New Revision: 354811
>>
>>URL: http://svn.apache.org/viewcvs?rev=354811&view=rev
>>Log:
>>PR: MNG-1379
>>
>>Commented out the line in EclipsePlugin.java that reconfigures the artifact file based on dependency systemPath, and reran the tests...it seems to pass just fine, so I assume the problem has been fixed as a side effect of another issue's resolution. I'm leaving the code in there (but commenting out the method call), just in case this proves to be incorrect.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r354811 - /maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/EclipsePlugin.java
Posted by Fabrizio Giustina <fg...@gmail.com>.
Hi John
if you remove this, the plugin will require maven 2.0.1 in order to
generate correct system dependencies. What about leaving it as is for
backward compatibility?
fabrizio
On 12/7/05, jdcasey@apache.org <jd...@apache.org> wrote:
> Author: jdcasey
> Date: Wed Dec 7 09:39:54 2005
> New Revision: 354811
>
> URL: http://svn.apache.org/viewcvs?rev=354811&view=rev
> Log:
> PR: MNG-1379
>
> Commented out the line in EclipsePlugin.java that reconfigures the artifact file based on dependency systemPath, and reran the tests...it seems to pass just fine, so I assume the problem has been fixed as a side effect of another issue's resolution. I'm leaving the code in there (but commenting out the method call), just in case this proves to be incorrect.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org