[GitHub] mistercrunch opened a new pull request #5661: [bugfix] TypeError: adhocMetric.comparator.join is not a function

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #5661: [bugfix] TypeError: adhocMetric.comparator.join is not a function
URL: https://github.com/apache/incubator-superset/pull/5661
 
 
   Somehow we have a "IN" filter where the filter is a string, not an
   array. While this may need to get fixed upstream as well, this prevents
   the explore view from completely crashing.
   
   Side note: this function looked somewhat brittle, I'm assuming it's used to keep
   the free form SQL tab in sync and not used to generate the actual SQL
   being executed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org