You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 22:12:10 UTC
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9017: [sip-15] Enabling SIP-15 by default
etr2460 commented on a change in pull request #9017: [sip-15] Enabling SIP-15 by default
URL: https://github.com/apache/incubator-superset/pull/9017#discussion_r370865438
##########
File path: superset/config.py
##########
@@ -748,7 +748,7 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
#
# Note if no end date for the grace period is specified then the grace period is
# indefinite.
-SIP_15_ENABLED = False
+SIP_15_ENABLED = True
SIP_15_GRACE_PERIOD_END: Optional[date] = None # exclusive
Review comment:
Should we add in a grace period date here? Maybe `2020-03-31` or something like that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org