[GitHub] [arrow-datafusion] Dandandan commented on pull request #296: allow datafusion cli to take -- comments

[GitBox <gi...@apache.org>]

Dandandan commented on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835825711


   > > I am wondering, can't we fix the code so comments are parsed correctly rather than skipping them?
   > > I believe you might be able to change the code to add new lines rather than a space at the end of every line.
   > > ```rust
   > > query.push(' ');
   > > // To
   > > query.push('\n');
   > > ```
   > > 
   > > 
   > > This way we should also parse multiline comments, comments starting with a space, etc correctly.
   > 
   > @Dandandan thanks for the advise. i've updated the appending to use `\n` instead.
   > 
   > However I still think we shall skip `--` starting lines like the changes i made here, otherwise a line with `-- ;` will result in an error
   
   Fair enough, thanks! I think at some point we should remove the `;` check and work together with the parser to detect true statement endings. Untill then this seems a good compromise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org