[jira] [Commented] (TAJO-693) StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly

["Tajo QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940323#comment-13940323 ] 

Tajo QA commented on TAJO-693:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12635511/TAJO-693.patch
  against master revision 5f7934e.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/228//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/228//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/228//console

This message is automatically generated.

> StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly
> ------------------------------------------------------------------------
>
>                 Key: TAJO-693
>                 URL: https://issues.apache.org/jira/browse/TAJO-693
>             Project: Tajo
>          Issue Type: Bug
>          Components: query master
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating, 1.0-incubating
>
>         Attachments: TAJO-693.patch
>
>
> I missed some bug in TAJO-638. This patch fixes the bug essentially. StatusUpdateTransition is a multiple-arc transition class. It should return ONLY RUNNING. But, the current implementation can result in wrong state which not described in state machine.



--
This message was sent by Atlassian JIRA
(v6.2#6252)