[GitHub] [incubator-druid] leventov commented on a change in pull request #7925: Use ComplexMetrics.registerSerde() across the codebase

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7925: Use ComplexMetrics.registerSerde() across the codebase
URL: https://github.com/apache/incubator-druid/pull/7925#discussion_r296171497
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/serde/ComplexMetrics.java
 ##########
 @@ -37,11 +38,18 @@ public static ComplexMetricSerde getSerdeForType(String type)
     return complexSerializers.get(type);
   }
 
-  public static void registerSerde(String type, ComplexMetricSerde serde)
+  private static void registerSerde(String type, ComplexMetricSerde serde)
 
 Review comment:
   No need to have this as a separate method. Please merge into the other method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org