[GitHub] [curator] eolivelli commented on a change in pull request #372: CURATOR-582: Migrate to jUnit 5.6

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #372:
URL: https://github.com/apache/curator/pull/372#discussion_r475118012



##########
File path: curator-client/src/test/java/org/apache/curator/BasicTests.java
##########
@@ -30,15 +37,13 @@
 import org.apache.zookeeper.ZooDefs;
 import org.apache.zookeeper.ZooKeeper;
 import org.mockito.Mockito;
-import org.testng.Assert;
-import org.testng.annotations.Test;
 import java.util.concurrent.Callable;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 public class BasicTests extends BaseClassForTests
 {
-    @Test
+    @RepeatedIfExceptionsTest(repeats = BaseClassForTests.REPEATS)

Review comment:
       Isn't there any other way of achieve this behaviour? It looks quite awkward to use this custom annotation instead of a simple '@Test'

##########
File path: pom.xml
##########
@@ -657,6 +674,12 @@
                     <version>${maven-bundle-plugin-version}</version>
                 </plugin>
 
+                <plugin>
+                    <groupId>org.commonjava.maven.plugins</groupId>
+                    <artifactId>directory-maven-plugin</artifactId>

Review comment:
       What's the purpose of this plugin?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org