You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/11 21:40:19 UTC

[GitHub] [tvm] Lunderberg opened a new pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Lunderberg opened a new pull request #10229:
URL: https://github.com/apache/tvm/pull/10229


   - Modified `tvm.contrib.nvcc.get_cuda_version` to return a `(major,minor,release)` tuple rather than a float.
   
   - Implemented `tvm.testing.requries_nvcc_version` decorator to specify the minimum `(major,minor,release)` version needed to run a unit test.
   
   - Applied decorated to unit tests in `test_tir_ptx_mma.py` that fail on earlier nvcc versions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1040734463


   > Thank you, and more lint fixes applied. It looks like the issue in my local setup is that `black` can't be run from inside the `python/tvm/contrib`, because `python/tvm/contrib/random.py` prevents it from importing the standard library `random`.
   
   Yeah that happens to me to. I always do `tests/lint/git-black.sh -i upstream/main`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] Lunderberg commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1041910557


   Bumped the commit to restart CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] Lunderberg commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1040347110


   Thank you, and the lint errors should be resolved now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] Lunderberg commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1040730935


   Thank you, and more lint fixes applied.  It looks like the issue in my local setup is that `black` can't be run from inside the `python/tvm/contrib`, because `python/tvm/contrib/random.py` prevents it from importing the standard library `random`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi merged pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10229:
URL: https://github.com/apache/tvm/pull/10229


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1039822161


   @Lunderberg Please take a look at the CI problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1039822161


   @Lunderberg Please take a look at the CI problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] Lunderberg commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1040347110


   Thank you, and the lint errors should be resolved now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #10229: [UnitTest] Disable ptx mma tests on unsupported nvcc versions.

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10229:
URL: https://github.com/apache/tvm/pull/10229#issuecomment-1040721744


   @Lunderberg Need more lint fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org