[GitHub] [spark] slothspot commented on a change in pull request #34071: [SPARK-36168][BUILD] Add support for Scala 2.13 in dev/test-dependencies.sh

[GitBox <gi...@apache.org>]

slothspot commented on a change in pull request #34071:
URL: https://github.com/apache/spark/pull/34071#discussion_r715066026



##########
File path: dev/test-dependencies.sh
##########
@@ -126,8 +121,8 @@ for HADOOP_HIVE_PROFILE in "${HADOOP_HIVE_PROFILES[@]}"; do
   dep_diff="$(
     git diff \
     --no-index \
-    dev/deps/spark-deps-$HADOOP_HIVE_PROFILE \
-    dev/pr-deps/spark-deps-$HADOOP_HIVE_PROFILE \
+    dev/deps/spark-deps-$HADOOP_HIVE_PROFILE-scala-$SCALA_BINARY_VERSION \

Review comment:
       @dongjoon-hyun  Shall I interpret old files as scala-2.12 before rename or do some content-based test to derive which profile been used to obtain one?
   And to clarify usage of this script: shall it iterate over both scala versions and generate two manifests or rely upon profile selected by the `./dev/change-scala-version`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org