[jira] [Commented] (MNG-6865) copy in object scope rather in class scope

["Karl Heinz Marbaise (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055251#comment-17055251 ] 

Karl Heinz Marbaise commented on MNG-6865:
------------------------------------------

Have you taken a look where the interface {{MavenExecutionRequest}} is being used? That would be breaking change if we would change that interface isn't that the case? 

> copy in object scope rather in class scope
> ------------------------------------------
>
>                 Key: MNG-6865
>                 URL: https://issues.apache.org/jira/browse/MNG-6865
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>            Reporter: Arne Lewinski
>            Priority: Minor
>
> This refactoring refers to a more intuitive API approach.
> The interface "MavenExecutionRequest" should provide an object scope method to copy itself. This has to be implemented by each sub type of "MavenExecutionRequest". Neverteless: I only found the class "DefaultMavenExecutionRequest" implementing the interface.
>  # Providing an object scope copy method makes the usage less verbose.
>  # As the copy method is defined abstract: the MavenCli class got rid of the concrete class "DefaultMavenExecutionRequest" dependency
> The static copy method should be declared deprecated and can be made private in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)