You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/10 22:47:23 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4695:
[Resource Assignment] Plug in resource assignment to LLC REALTIME table
codecov-io edited a comment on issue #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table
URL: https://github.com/apache/incubator-pinot/pull/4695#issuecomment-540783768
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=h1) Report
> Merging [#4695](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/b824b480f1110a16d5157f6a8cbd96cf860a6bf8?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `77.97%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4695 +/- ##
============================================
+ Coverage 64.75% 64.86% +0.11%
Complexity 16 16
============================================
Files 1061 1052 -9
Lines 56673 56277 -396
Branches 8418 8347 -71
============================================
- Hits 36696 36504 -192
+ Misses 17268 17058 -210
- Partials 2709 2715 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/common/config/IndexingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0luZGV4aW5nQ29uZmlnLmphdmE=) | `52.29% <ø> (-1.28%)` | `0 <0> (ø)` | |
| [...org/apache/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyU3RhcnRlci5qYXZh) | `70% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `79.52% <ø> (-0.42%)` | `0 <0> (ø)` | |
| [...ore/assignment/segment/SegmentAssignmentUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9TZWdtZW50QXNzaWdubWVudFV0aWxzLmphdmE=) | `97.47% <ø> (+0.84%)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/pinot/common/config/TagNameUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhZ05hbWVVdGlscy5qYXZh) | `67.74% <ø> (+6.63%)` | `0 <0> (ø)` | :arrow_down: |
| [...segment/SegmentSizeBasedFlushThresholdUpdater.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvU2VnbWVudFNpemVCYXNlZEZsdXNoVGhyZXNob2xkVXBkYXRlci5qYXZh) | `70.76% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...roller/helix/core/PinotTableIdealStateBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90VGFibGVJZGVhbFN0YXRlQnVpbGRlci5qYXZh) | `80.51% <100%> (+1.76%)` | `0 <0> (ø)` | :arrow_down: |
| [...realtime/segment/DefaultFlushThresholdUpdater.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvRGVmYXVsdEZsdXNoVGhyZXNob2xkVXBkYXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../realtime/segment/FlushThresholdUpdateManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvRmx1c2hUaHJlc2hvbGRVcGRhdGVNYW5hZ2VyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/incubator-pinot/pull/4695/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=footer). Last update [b824b48...0c8eb01](https://codecov.io/gh/apache/incubator-pinot/pull/4695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org