You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/13 15:14:20 UTC
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs of complex types about ORC support
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12744
Change subject: IMPALA-8298: [DOCS] Update docs of complex types about ORC support
......................................................................
IMPALA-8298: [DOCS] Update docs of complex types about ORC support
Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
---
M docs/shared/impala_common.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_orc.xml
M docs/topics/impala_parquet.xml
4 files changed, 44 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/12744/1
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
Patch Set 3:
Thank Alex for your review!
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 01:33:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/270/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 17:34:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Reviewed-on: http://gerrit.cloudera.org:8080/12744
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_orc.xml
M docs/topics/impala_parquet.xml
4 files changed, 68 insertions(+), 88 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs of complex types about ORC support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs of complex types about ORC support
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/269/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 15:14:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs of complex types about ORC support
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs of complex types about ORC support
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12744/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12744/1//COMMIT_MSG@7
PS1, Line 7: of complex types about ORC support
for complex type support in ORC
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/shared/impala_common.xml@2181
PS1, Line 2181: impala_complex_types.xml
../topics/impala_complex_types.xml
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml
File docs/topics/impala_complex_types.xml:
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@347
PS1, Line 347: format
formats
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@1671
PS1, Line 1671: data
or ORC data
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@1675
PS1, Line 1675: The same for ORC file format.
Remove this after adding ORC at line 1671.
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 17:00:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs of complex types about ORC support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs of complex types about ORC support
......................................................................
Patch Set 1: Verified-1
Build Failed
https://jenkins.impala.io/job/gerrit-docs-auto-test/269/ : Doc tests failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 15:32:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs of complex types about ORC support
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs of complex types about ORC support
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml
File docs/topics/impala_complex_types.xml:
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@347
PS1, Line 347: or
and
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@1671
PS1, Line 1671: data
> or ORC data
Ignore this comment
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@1674
PS1, Line 1674: the
Parquet or ORC
http://gerrit.cloudera.org:8080/#/c/12744/1/docs/topics/impala_complex_types.xml@1675
PS1, Line 1675: The same for ORC file format.
> Remove this after adding ORC at line 1671.
Ignore this comment
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 17:31:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/270/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 17:51:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:04:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
Patch Set 3:
Thank you for drafting the doc, Quanlong!
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2019 02:03:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has uploaded a new patch set (#2) to the change originally created by Quanlong Huang. ( http://gerrit.cloudera.org:8080/12744 )
Change subject: IMPALA-8298: [DOCS] Update docs for complex types support in ORC
......................................................................
IMPALA-8298: [DOCS] Update docs for complex types support in ORC
Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
---
M docs/shared/impala_common.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_orc.xml
M docs/topics/impala_parquet.xml
4 files changed, 68 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/12744/2
--
To view, visit http://gerrit.cloudera.org:8080/12744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I261d41f536d653033cc1083873edf8c83508fdb7
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>