You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/09 15:59:07 UTC
Review Request 47122: GEODE-1350: prepare the tests to use
JunitParamsRunner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47122/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Kirk Lund.
Repository: geode
Description
-------
GEODE-1350: prepare the tests to use JunitParamsRunner instead
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java caee9eaeed6c5cda363cb7352d6bd18ea0867d3f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 0486c5ace90316f9afedb61e78ca59756f630058
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c34214217c69ad9d3b50d63ad83f08f4e82f20be
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConnectCommandWithHttpAndSSLDUnitTest.java 2e0897d0877b9673c05821bcf5b0b2fc1aeb55f0
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 530428d1d4a2ea50b774bdc09dfae53fc181452c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 7d1a7ff0457e9cfa0373afab1e1f7ae2a5308b7a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 2502a4b6f797017f78c919a0051ac86a8428a2d8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8d1252b8d698f1289d214ef1e0a2a4388f8c8bb7
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java eed7db1ba2449c2561232afef9a7071d47b78f78
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 781ed982a855d0d0cd31c1ebcc352fe46871417b
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java d96c96cabc383ce03f641abfbd98b803182c24f2
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshShellConnectionRule.java d0f33d9e4b1285b51edffe31563afd0ccc2b0dd9
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 62bb793cc91f5a7a68daba133e77e800855f0e4d
Diff: https://reviews.apache.org/r/47122/diff/
Testing
-------
running precheckin....
Thanks,
Jinmei Liao
Re: Review Request 47122: GEODE-1350: prepare the tests to use
JunitParamsRunner
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47122/#review132320
-----------------------------------------------------------
Fix it, then Ship it!
I'm assuming the plan is to follow this up with another commit that uncomments the usage of JUnitParams?
Fix any issues and then ship it!
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java (line 45)
<https://reviews.apache.org/r/47122/#comment196504>
Delete this import
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java (line 154)
<https://reviews.apache.org/r/47122/#comment196505>
We should either a) store LogService.getLogger() in a private static final variable because it's a creator not a getter or b) change to System.out.println or c) just delete this
- Kirk Lund
On May 9, 2016, 3:59 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47122/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 3:59 p.m.)
>
>
> Review request for geode, Jens Deppe and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1350: prepare the tests to use JunitParamsRunner instead
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java caee9eaeed6c5cda363cb7352d6bd18ea0867d3f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 0486c5ace90316f9afedb61e78ca59756f630058
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c34214217c69ad9d3b50d63ad83f08f4e82f20be
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConnectCommandWithHttpAndSSLDUnitTest.java 2e0897d0877b9673c05821bcf5b0b2fc1aeb55f0
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 530428d1d4a2ea50b774bdc09dfae53fc181452c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 7d1a7ff0457e9cfa0373afab1e1f7ae2a5308b7a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 2502a4b6f797017f78c919a0051ac86a8428a2d8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8d1252b8d698f1289d214ef1e0a2a4388f8c8bb7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java eed7db1ba2449c2561232afef9a7071d47b78f78
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 781ed982a855d0d0cd31c1ebcc352fe46871417b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java d96c96cabc383ce03f641abfbd98b803182c24f2
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshShellConnectionRule.java d0f33d9e4b1285b51edffe31563afd0ccc2b0dd9
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 62bb793cc91f5a7a68daba133e77e800855f0e4d
>
> Diff: https://reviews.apache.org/r/47122/diff/
>
>
> Testing
> -------
>
> running precheckin....
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 47122: GEODE-1350: prepare the tests to use
JunitParamsRunner
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47122/#review132434
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On May 9, 2016, 3:59 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47122/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 3:59 p.m.)
>
>
> Review request for geode, Jens Deppe and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1350: prepare the tests to use JunitParamsRunner instead
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java caee9eaeed6c5cda363cb7352d6bd18ea0867d3f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 0486c5ace90316f9afedb61e78ca59756f630058
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java c34214217c69ad9d3b50d63ad83f08f4e82f20be
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConnectCommandWithHttpAndSSLDUnitTest.java 2e0897d0877b9673c05821bcf5b0b2fc1aeb55f0
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 530428d1d4a2ea50b774bdc09dfae53fc181452c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java 7d1a7ff0457e9cfa0373afab1e1f7ae2a5308b7a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 2502a4b6f797017f78c919a0051ac86a8428a2d8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/FunctionCommandsDUnitTest.java 8d1252b8d698f1289d214ef1e0a2a4388f8c8bb7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java eed7db1ba2449c2561232afef9a7071d47b78f78
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java 781ed982a855d0d0cd31c1ebcc352fe46871417b
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshCommandsSecurityTest.java d96c96cabc383ce03f641abfbd98b803182c24f2
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshShellConnectionRule.java d0f33d9e4b1285b51edffe31563afd0ccc2b0dd9
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 62bb793cc91f5a7a68daba133e77e800855f0e4d
>
> Diff: https://reviews.apache.org/r/47122/diff/
>
>
> Testing
> -------
>
> running precheckin....
>
>
> Thanks,
>
> Jinmei Liao
>
>