You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 01:54:48 UTC
[GitHub] [arrow-datafusion] viirya opened a new issue #1920: Add timeout to can_grow_directly
viirya opened a new issue #1920:
URL: https://github.com/apache/arrow-datafusion/issues/1920
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
In `MemoryManager`, `can_grow_directly` tries to grow memory attempt and blocks the thread when it cannot acquire for a least amount of memory (`Condvar.wait`). It looks a bit strange to wait forever for other consumers to spill there. Because it doesn't actually trigger other consumers to do spilling but just passively waits for notification once other consumers do spilling, in worse case it might wait for very long time. In such case, it seems more ideal to wait for a duration, and spill by itself if timeout happens.
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya closed issue #1920: Add timeout to can_grow_directly
Posted by GitBox <gi...@apache.org>.
viirya closed issue #1920:
URL: https://github.com/apache/arrow-datafusion/issues/1920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org