Re: Comments on current patches.

[Randy Terbush <ra...@zyzzyva.com>]

> I just looked at the patches/for_Apache_0.8.13 directory.  A few comments:
> 
> First off, it looks to me like the 01* patches (in for_Apache_0.8.13) are
> intended to fix the problem that the itime patch to mod_log_config which was
> offered last time does not compile.  However, adding the extra include line
> is pointless unless you also toss in the itime modification itself, which is
> not included in either of these patches.  The right thing here is a *single*
> patch (not two, not three) which, when applied to mod_log_config, creates a
> new version which includes the itime patch *and* everything else needed to
> make it compile cleanly in context.  As is, these patches just dink
> mod_log_config without doing anything useful.

I just uploaded 01a_log_config_integer_time.0.8.13.patch.

It includes the few changes to support integer time format, and
adds the needed #include that was missing from last weeks patch.

There was one other change in the previous 01_ patch that I did not
include that Aram had added to his patch. I suspect that this is a
change to remove some warnings for the Linux du jour?  They should
probably be in another patch since they don't apply to the integer
time changes, that I am aware of.


*** conf.h.orig Tue Sep 12 11:30:23 1995
--- conf.h      Tue Sep 12 11:30:29 1995
***************
*** 181,189 ****
  #undef NO_KILLPG
  #undef NO_SETSID
  #undef NEED_STRDUP
- #define FD_SET __FD_SET
- #define FD_ZERO __FD_ZERO
- #define FD_ISSET __FD_ISSET
  #define JMP_BUF sigjmp_buf
  #define FCNTL_SERIALIZED_ACCEPT