You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/04/27 21:31:11 UTC
[GitHub] [incubator-pinot] npawar opened a new pull request #5310: Move ExpressionEvaluators and SchemaFieldExtractor from pinot-spi to pinot-core
npawar opened a new pull request #5310:
URL: https://github.com/apache/incubator-pinot/pull/5310
Moving the ExpressionEvaluators to pinot-core, so that it can be alongside the FunctionExpressionEvaluators related code.
Also moved SchemaFieldExtractorUtils to pinot-core, and renamed it to SchemaUtils. This SchemaUtils (which contains validate) and the SchemaUtils in pinot-common (which contains from/to ZnRecord), should be merged into 1 eventually. Can be done when pinot-core and pinot-common modules get merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #5310: Move ExpressionEvaluators and SchemaFieldExtractor from pinot-spi to pinot-core
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #5310:
URL: https://github.com/apache/incubator-pinot/pull/5310#issuecomment-620284903
> LGTM. This one has conflict with #5309. Let's figure out which one to merge first
As discussed offline, I'll merge this first. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #5310: Move ExpressionEvaluators and SchemaFieldExtractor from pinot-spi to pinot-core
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #5310:
URL: https://github.com/apache/incubator-pinot/pull/5310#issuecomment-625541254
https://github.com/apache/incubator-pinot/issues/5352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org