You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/19 15:46:46 UTC
[GitHub] [maven-scm] G-Ork opened a new pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
G-Ork opened a new pull request #132:
URL: https://github.com/apache/maven-scm/pull/132
Thrird try to fix [SCM-925]
- Implement remove command for JGit provider
- Write TCK for remove command.
- Changed JGIT from 4.5.4.201711221230-r to 5.13.0.202109080827-r
- Changed Java from 1.7 to 1.8 (JGit moves forward)
- Change codehaus java checks from 1.7 to 1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r775664327
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -88,4 +95,11 @@
</plugin>
</plugins>
</build>
+
+ <properties>
+ <!-- jgit version: 6.0.0.202111291000-r need java 11
+ jgit version: 5.13.0.202109080827-r need java 8
+ -->
+ <org.eclipse.jgit.version>5.13.0.202109080827-r</org.eclipse.jgit.version>
Review comment:
Since this requires Java 8, it won't happen in 1.x. Can this be done with an older version?
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -50,9 +50,16 @@
<dependency>
<groupId>org.eclipse.jgit</groupId>
<artifactId>org.eclipse.jgit</artifactId>
- <version>4.5.4.201711221230-r</version>
+ <version>${org.eclipse.jgit.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jgit</groupId>
+ <artifactId>org.eclipse.jgit.ssh.jsch</artifactId>
+ <version>${org.eclipse.jgit.version}</version>
Review comment:
Why is this necessary? JGit has moved to MINA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] G-Ork commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
G-Ork commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r776163912
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -50,9 +50,16 @@
<dependency>
<groupId>org.eclipse.jgit</groupId>
<artifactId>org.eclipse.jgit</artifactId>
- <version>4.5.4.201711221230-r</version>
+ <version>${org.eclipse.jgit.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jgit</groupId>
+ <artifactId>org.eclipse.jgit.ssh.jsch</artifactId>
+ <version>${org.eclipse.jgit.version}</version>
Review comment:
Just try to maintain and upgrade an old dependency. Is there any problem with apache MINA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r776271551
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -50,9 +50,16 @@
<dependency>
<groupId>org.eclipse.jgit</groupId>
<artifactId>org.eclipse.jgit</artifactId>
- <version>4.5.4.201711221230-r</version>
+ <version>${org.eclipse.jgit.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jgit</groupId>
+ <artifactId>org.eclipse.jgit.ssh.jsch</artifactId>
+ <version>${org.eclipse.jgit.version}</version>
Review comment:
No problem with MINA, as far as I understood the JSch approach is dead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] G-Ork commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
G-Ork commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r776163474
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -88,4 +95,11 @@
</plugin>
</plugins>
</build>
+
+ <properties>
+ <!-- jgit version: 6.0.0.202111291000-r need java 11
+ jgit version: 5.13.0.202109080827-r need java 8
+ -->
+ <org.eclipse.jgit.version>5.13.0.202109080827-r</org.eclipse.jgit.version>
Review comment:
It is not neccesary. I just tried to upgrade some very old dependencies. Git is evolving, JGIT shurely fixes a lot of bugs. Maven also moved to Java 8. It is paradox to fix something and keep downward compatibility while everyone moving forward.
Are there plans to upgrade the plugins to 3.x?
But my heart whont bleed if keeping the old dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] G-Ork commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
G-Ork commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r776163474
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -88,4 +95,11 @@
</plugin>
</plugins>
</build>
+
+ <properties>
+ <!-- jgit version: 6.0.0.202111291000-r need java 11
+ jgit version: 5.13.0.202109080827-r need java 8
+ -->
+ <org.eclipse.jgit.version>5.13.0.202109080827-r</org.eclipse.jgit.version>
Review comment:
It is not neccesary. I just tried to upgrade some very old dependencies. Git is evolving, JGit shurely fixes a lot of bugs. Maven also moved to Java 8. It is paradox to fix something and keep downward compatibility while everyone moving forward.
Are there plans to upgrade the plugins to 3.x?
But my heart wont bleed if keeping the old dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#issuecomment-997414521
Massive, thanks. Will take a look during Christmas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#discussion_r776271733
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml
##########
@@ -88,4 +95,11 @@
</plugin>
</plugins>
</build>
+
+ <properties>
+ <!-- jgit version: 6.0.0.202111291000-r need java 11
+ jgit version: 5.13.0.202109080827-r need java 8
+ -->
+ <org.eclipse.jgit.version>5.13.0.202109080827-r</org.eclipse.jgit.version>
Review comment:
The 1.x line will remain on Java 7. 2.x will move to Java 8. So please make a decision how imporant this is for you then I can continue to review your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] natami commented on pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
Posted by GitBox <gi...@apache.org>.
natami commented on pull request #132:
URL: https://github.com/apache/maven-scm/pull/132#issuecomment-1020065978
Any progress on this change? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org