You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by WeichenXu123 <gi...@git.apache.org> on 2016/08/27 14:48:30 UTC
[GitHub] zeppelin pull request #1372: [ZEPPELIN-1383][ Interpreters][r-interpreter] r...
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/zeppelin/pull/1372
[ZEPPELIN-1383][ Interpreters][r-interpreter] remove SparkInterpreter.getSystemDefault and update relative code
### What is this PR for?
clean some redundant code:
remove `SparkInterpreter.getSystemDefault` methods,
and replace it with `InterpreterProperty.getValue`
### What type of PR is it?
Improvement
### Todos
N/A
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1383
remove SparkInterpreter.getSystemDefault and update relative code
### How should this be tested?
Existing tests.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/zeppelin remove_spark_interpreter_getSystemDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1372
----
commit cdea57cf716cf2959273c7dc7780ebd5c7abee77
Author: WeichenXu <we...@outlook.com>
Date: 2016-08-27T13:51:30Z
update.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1372: [ZEPPELIN-1383][ Interpreters][r-interpreter] r...
Posted by WeichenXu123 <gi...@git.apache.org>.
GitHub user WeichenXu123 reopened a pull request:
https://github.com/apache/zeppelin/pull/1372
[ZEPPELIN-1383][ Interpreters][r-interpreter] remove SparkInterpreter.getSystemDefault and update relative code
### What is this PR for?
clean some redundant code:
remove `SparkInterpreter.getSystemDefault` methods,
and replace it with `InterpreterProperty.getValue`
### What type of PR is it?
Improvement
### Todos
N/A
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1383
remove SparkInterpreter.getSystemDefault and update relative code
### How should this be tested?
Existing tests.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/zeppelin remove_spark_interpreter_getSystemDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1372
----
commit 841b757690d41ef3bb162d8089cc0bad16333602
Author: WeichenXu <we...@outlook.com>
Date: 2016-08-27T13:51:30Z
update.
commit 204a34c01ff8df61cc27833fc96cee6fb3ba81f1
Author: WeichenXu <we...@outlook.com>
Date: 2016-08-28T07:44:26Z
improve code stype.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1372: [ZEPPELIN-1383][ Interpreters][r-interpreter] remove S...
Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 commented on the issue:
https://github.com/apache/zeppelin/pull/1372
cc @jongyoul @Leemoonsoo Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1372: [ZEPPELIN-1383][ Interpreters][r-interpreter] r...
Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/zeppelin/pull/1372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1372: [ZEPPELIN-1383][ Interpreters][r-interpreter] remove S...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1372
I think it's enough for my purpose. Thanks. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1372: [ZEPPELIN-1383][ Interpreters][r-interpreter] r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---