You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/07 12:45:43 UTC
[GitHub] [hive] pvargacl opened a new pull request #1220: HIVE-23413: Create a new config to skip all locks
pvargacl opened a new pull request #1220:
URL: https://github.com/apache/hive/pull/1220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-688557508
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-690931518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1220:
URL: https://github.com/apache/hive/pull/1220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-690931518
> @pvary So what is the conclusion? Should I add it to the restricted list by default? Or will you merge this, as is?
I would like to see an agreement here. This is more like a democratic process, than autocratic :)
I still think this will become useful immediately when someone has a problem with the too restrictive locking. If in doubt we might just add this to HIVE_CONF_RESTRICTED_LIST, so no rouge user can use this unless the administrator explicitly allows the usage of the new config.
But this is only me, others might different opinions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1220:
URL: https://github.com/apache/hive/pull/1220#discussion_r484757467
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -727,35 +751,52 @@ private void testCheckExpectedLocks(boolean sharedWrite) throws Exception {
*/
@Test
public void testCheckExpectedLocks2() throws Exception {
+ testCheckExpectedLocks2(true);
+ }
+ @Test
+ public void testCheckExpectedLocks2NoReadLock() throws Exception {
+ testCheckExpectedLocks2(false);
+ }
+ public void testCheckExpectedLocks2(boolean readLocks) throws Exception {
Review comment:
nit: new row
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -727,35 +751,52 @@ private void testCheckExpectedLocks(boolean sharedWrite) throws Exception {
*/
@Test
public void testCheckExpectedLocks2() throws Exception {
+ testCheckExpectedLocks2(true);
+ }
+ @Test
Review comment:
nit: new row
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvargacl commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvargacl commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-690929320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-725051537
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvargacl commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvargacl commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-690929320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvargacl commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvargacl commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-655935856
@deniskuzZ could you check this out, you already reviewed it on the review board, but I forgat about it, so now created a PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-689452296
> Checked, however I'm not sure if it is a good idea to give the end user the option to completely disable the locking. They could end up shooting themselves in the foot.
Administrator could add it to the restricted parameters which can not be set by the user, so a customer can turn off if they feel it is problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvargacl commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvargacl commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-688708402
@deniskuzZ @pvary Do you still think we need this? If so please review, and I will check if it needs rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-690931518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvargacl commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
pvargacl commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-690929320
@pvary So what is the conclusion? Should I add it to the restricted list by default? Or will you merge this, as is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on pull request #1220: HIVE-23413: Create a new config to skip all locks
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on pull request #1220:
URL: https://github.com/apache/hive/pull/1220#issuecomment-689372016
Checked, however I'm not sure if it is a good idea to give the end user the option to completely disable the locking. They could end up shooting themselves in the foot.
From code perspective, change looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org