You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by ThisuraThejith <gi...@git.apache.org> on 2017/06/25 05:48:55 UTC
[GitHub] fineract pull request #375: FINERACT-437-Remove generic exceptions
GitHub user ThisuraThejith opened a pull request:
https://github.com/apache/fineract/pull/375
FINERACT-437-Remove generic exceptions
Add well defined exception for exceptions thrown by the fineract to resolve error MITRE, CWE-397 - Declaration of Throws for Generic Exception.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThisuraThejith/incubator-fineract FINERACT-437
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/fineract/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit 3be98325e1b81f6b75dc1e0d5202c53ad365a866
Author: ThisuraThejith <tt...@gmail.com>
Date: 2017-06-25T05:45:54Z
Add welldefined exception for exceptions thrown by the fineract
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #375: FINERACT-437-Remove generic exceptions
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/fineract/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #375: FINERACT-437-Remove generic exceptions
Posted by ThisuraThejith <gi...@git.apache.org>.
Github user ThisuraThejith commented on the issue:
https://github.com/apache/fineract/pull/375
@nazeer1100126 I have updated the PR. Please review and let me know if there are any issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #375: FINERACT-437-Remove generic exceptions
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/375
@ThisuraThejith I suggest to have separate exception classes or generic type exceptions (for each sms and journaly entry) which takes errorcode, user message in the constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #375: FINERACT-437-Remove generic exceptions
Posted by ThisuraThejith <gi...@git.apache.org>.
Github user ThisuraThejith commented on the issue:
https://github.com/apache/fineract/pull/375
@nazeer1100126 Sure will do that. So instead of enums we'll pass the error codes and the message in the constructor when we are throwing them, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---