[GitHub] [flink] reswqa commented on a diff in pull request #21331: [FLINK-29639] Print resourceId of remote taskmanager when encounter transport exception.

[GitBox <gi...@apache.org>]

reswqa commented on code in PR #21331:
URL: https://github.com/apache/flink/pull/21331#discussion_r1023929635


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ConnectionID.java:
##########
@@ -43,18 +46,36 @@ public class ConnectionID implements Serializable {
 
     private final int connectionIndex;
 
+    /**
+     * Resource ID can be known from shuffleDescriptor, to avoid rpc overhead,
+     * PartitionConnectionInfo will carry a connectionId with null resourceID.

Review Comment:
   This is because `NettyShuffleDescriptor#fromProducerDescriptor` will create a `NetworkPartitionConnectionInfo`, which will carry a `ConnectionID`. If this connectionId carries a `ResourceID`, the RPC message will become larger.
   
   BTW. Through offline discussion with @xintongsong , it is better to directly maintain address and connectionIndex in `NetworkPartitionConnectionInfo`. This can avoid the potentially null `ResourceID` and reduce the network transmission cost also.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org