You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/21 20:42:41 UTC
[GitHub] [superset] jayakrishnankk opened a new pull request #18133: Migrating storybook jsx to typescript #18100
jayakrishnankk opened a new pull request #18133:
URL: https://github.com/apache/superset/pull/18133
### SUMMARY
Migrated EmbedCodeButton to TypeScript to apply direction outlined in #18100
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No changes
### TESTING INSTRUCTIONS
Storybook can be used to verify those changes.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #18100
- [ ] Required feature flags: no
- [ ] Changes UI: no
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)): no
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API: no
- [ ] Removes existing feature or API: no
tagging @ad-m , @zhaoyongjie , @kristw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18133:
URL: https://github.com/apache/superset/pull/18133#issuecomment-1018873112
# [Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18133](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5b8ffa) into [master](https://codecov.io/gh/apache/superset/commit/e9651ea52fdc0edb574bfb9dc1b22c225bcc068f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9651ea) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18133 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 1584 1584
Lines 62046 62046
Branches 6273 6273
=======================================
Hits 40920 40920
Misses 19505 19505
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/time-format/TimeFormatterRegistrySingleton.ts](https://codecov.io/gh/apache/superset/pull/18133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5U2luZ2xldG9uLnRz) | `100.00% <ø> (ø)` | |
| [...s/legacy-plugin-chart-country-map/src/countries.ts](https://codecov.io/gh/apache/superset/pull/18133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNvdW50cnktbWFwL3NyYy9jb3VudHJpZXMudHM=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e9651ea...e5b8ffa](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18133:
URL: https://github.com/apache/superset/pull/18133#issuecomment-1018873112
# [Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18133](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2027a22) into [master](https://codecov.io/gh/apache/superset/commit/e9651ea52fdc0edb574bfb9dc1b22c225bcc068f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9651ea) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2027a22 differs from pull request most recent head e5b8ffa. Consider uploading reports for the commit e5b8ffa to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18133 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 1584 1584
Lines 62046 62046
Branches 6273 6273
=======================================
Hits 40920 40920
Misses 19505 19505
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e9651ea...e5b8ffa](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18133: Migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18133:
URL: https://github.com/apache/superset/pull/18133#issuecomment-1018873112
# [Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18133](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2027a22) into [master](https://codecov.io/gh/apache/superset/commit/e9651ea52fdc0edb574bfb9dc1b22c225bcc068f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9651ea) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18133 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 1584 1584
Lines 62046 62046
Branches 6273 6273
=======================================
Hits 40920 40920
Misses 19505 19505
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.88% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e9651ea...2027a22](https://codecov.io/gh/apache/superset/pull/18133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jayakrishnankk commented on a change in pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
jayakrishnankk commented on a change in pull request #18133:
URL: https://github.com/apache/superset/pull/18133#discussion_r790390835
##########
File path: superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.tsx
##########
@@ -17,41 +17,37 @@
* under the License.
*/
-/* eslint-disable jsx-a11y/label-has-associated-control */
import React from 'react';
import { formatNumber } from '@superset-ui/core';
-const propTypes = {};
-const defaultProps = {};
-
class NumberFormatValidator extends React.PureComponent {
+ state: { formatString: string; testValues: any[] } = {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #18133:
URL: https://github.com/apache/superset/pull/18133#discussion_r790095719
##########
File path: superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.tsx
##########
@@ -17,41 +17,37 @@
* under the License.
*/
-/* eslint-disable jsx-a11y/label-has-associated-control */
import React from 'react';
import { formatNumber } from '@superset-ui/core';
-const propTypes = {};
-const defaultProps = {};
-
class NumberFormatValidator extends React.PureComponent {
+ state: { formatString: string; testValues: any[] } = {
Review comment:
```suggestion
state: { formatString: string; testValues: (number | null | undefined)[] } = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #18133:
URL: https://github.com/apache/superset/pull/18133#discussion_r790095806
##########
File path: superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormatStories.tsx
##########
@@ -17,30 +17,25 @@
* under the License.
*/
-/* eslint-disable jsx-a11y/label-has-associated-control */
import React from 'react';
import { formatTime } from '@superset-ui/core';
-const propTypes = {};
-const defaultProps = {};
-
class TimeFormatValidator extends React.PureComponent {
+ state: { formatString: string; testValues: any[] } = {
Review comment:
same as above.
```suggestion
state: { formatString: string; testValues: (Date | number | null | undefined)[] } = {
```
##########
File path: superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.tsx
##########
@@ -17,41 +17,37 @@
* under the License.
*/
-/* eslint-disable jsx-a11y/label-has-associated-control */
import React from 'react';
import { formatNumber } from '@superset-ui/core';
-const propTypes = {};
-const defaultProps = {};
-
class NumberFormatValidator extends React.PureComponent {
+ state: { formatString: string; testValues: any[] } = {
Review comment:
```suggestion
state: { formatString: string; testValues: (number | null | undefined)[] } = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jayakrishnankk commented on a change in pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
jayakrishnankk commented on a change in pull request #18133:
URL: https://github.com/apache/superset/pull/18133#discussion_r790390383
##########
File path: superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormatStories.tsx
##########
@@ -17,30 +17,25 @@
* under the License.
*/
-/* eslint-disable jsx-a11y/label-has-associated-control */
import React from 'react';
import { formatTime } from '@superset-ui/core';
-const propTypes = {};
-const defaultProps = {};
-
class TimeFormatValidator extends React.PureComponent {
+ state: { formatString: string; testValues: any[] } = {
Review comment:
This typing do suggest another change in the file
`superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts::formatTime() method`
`value: Date | number | null | undefined, --> value: Date | null | undefined,` Hope it is okay to change this. Functionally it seem to work. So making that change also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #18133: chore: migrating storybook jsx to typescript #18100
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #18133:
URL: https://github.com/apache/superset/pull/18133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org