You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/09/09 11:44:19 UTC
[GitHub] [cordova-docs] erisu opened a new pull request, #1260: blog: media plugin 6.1.0 release
erisu opened a new pull request, #1260:
URL: https://github.com/apache/cordova-docs/pull/1260
Media 6.1.0 Release Blog Post
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on a diff in pull request #1260: blog: media plugin 6.1.0 release
Posted by GitBox <gi...@apache.org>.
breautek commented on code in PR #1260:
URL: https://github.com/apache/cordova-docs/pull/1260#discussion_r967845251
##########
www/_posts/2022-09-09-media-plugin-6.1.0.md:
##########
@@ -0,0 +1,35 @@
+---
+layout: post
+author:
+ name: Bryan Ellis
+title: "Media Plugin 6.1.0 Released!"
+categories: news
+tags: release plugins
+---
+
+We are happy to announce that we have just released an update for `cordova-plugin-media`!
+
+* [cordova-plugin-media@6.1.0](https://www.npmjs.com/package/cordova-plugin-media)
+
+**To upgrade:**
+
+```bash
+cordova plugin remove cordova-plugin-media
+cordova plugin add cordova-plugin-media@6.1.0
+```
+
+## Release Highlights
+
+For Android, we updated the media error response object to include the "message" property. This property will provide additional information about the error. It also syncs in line with the media error response object that iOS returns.
+
+For iOS, file scheme support has been implemented. Two fixes were applied to prevent crashes that occured when fetching the position while the time was not defined and to ensured that the category was defined after the recording was released.
+
+Please report any issues you find at [issues.cordova.io](http://issues.cordova.io/)!
Review Comment:
`issues.cordova.io` doesn't appear to exist, perhaps this should link to https://github.com/apache/cordova-plugin-media/issues instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on a diff in pull request #1260: blog: media plugin 6.1.0 release
Posted by GitBox <gi...@apache.org>.
breautek commented on code in PR #1260:
URL: https://github.com/apache/cordova-docs/pull/1260#discussion_r985104820
##########
www/_posts/2022-09-09-media-plugin-6.1.0.md:
##########
@@ -0,0 +1,35 @@
+---
+layout: post
+author:
+ name: Bryan Ellis
+title: "Media Plugin 6.1.0 Released!"
+categories: news
+tags: release plugins
+---
+
+We are happy to announce that we have just released an update for `cordova-plugin-media`!
+
+* [cordova-plugin-media@6.1.0](https://www.npmjs.com/package/cordova-plugin-media)
+
+**To upgrade:**
+
+```bash
+cordova plugin remove cordova-plugin-media
+cordova plugin add cordova-plugin-media@6.1.0
+```
+
+## Release Highlights
+
+For Android, we updated the media error response object to include the "message" property. This property will provide additional information about the error. It also syncs in line with the media error response object that iOS returns.
+
+For iOS, file scheme support has been implemented. Two fixes were applied to prevent crashes that occured when fetching the position while the time was not defined and to ensured that the category was defined after the recording was released.
+
+Please report any issues you find at [issues.cordova.io](http://issues.cordova.io/)!
Review Comment:
I think that's fine. My main concern was the broken link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu commented on a diff in pull request #1260: blog: media plugin 6.1.0 release
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #1260:
URL: https://github.com/apache/cordova-docs/pull/1260#discussion_r985053384
##########
www/_posts/2022-09-09-media-plugin-6.1.0.md:
##########
@@ -0,0 +1,35 @@
+---
+layout: post
+author:
+ name: Bryan Ellis
+title: "Media Plugin 6.1.0 Released!"
+categories: news
+tags: release plugins
+---
+
+We are happy to announce that we have just released an update for `cordova-plugin-media`!
+
+* [cordova-plugin-media@6.1.0](https://www.npmjs.com/package/cordova-plugin-media)
+
+**To upgrade:**
+
+```bash
+cordova plugin remove cordova-plugin-media
+cordova plugin add cordova-plugin-media@6.1.0
+```
+
+## Release Highlights
+
+For Android, we updated the media error response object to include the "message" property. This property will provide additional information about the error. It also syncs in line with the media error response object that iOS returns.
+
+For iOS, file scheme support has been implemented. Two fixes were applied to prevent crashes that occured when fetching the position while the time was not defined and to ensured that the category was defined after the recording was released.
+
+Please report any issues you find at [issues.cordova.io](http://issues.cordova.io/)!
Review Comment:
@breautek I updated the message and link.
IMO, I think it would be better to point to a generic link. Then the release blog post can be templated.
If the link was specific, anyone could accidentally forget to update the link when using the template.
Also, if the blog post was covering multiple package release, at the same time, then we have to change the entire message or repeat the sentence under each section.
Let me know what you think of the updated message, and what it points to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu commented on a diff in pull request #1260: blog: media plugin 6.1.0 release
Posted by GitBox <gi...@apache.org>.
erisu commented on code in PR #1260:
URL: https://github.com/apache/cordova-docs/pull/1260#discussion_r985052878
##########
www/_posts/2022-09-09-media-plugin-6.1.0.md:
##########
@@ -0,0 +1,35 @@
+---
+layout: post
+author:
+ name: Bryan Ellis
+title: "Media Plugin 6.1.0 Released!"
+categories: news
+tags: release plugins
+---
+
+We are happy to announce that we have just released an update for `cordova-plugin-media`!
+
+* [cordova-plugin-media@6.1.0](https://www.npmjs.com/package/cordova-plugin-media)
+
+**To upgrade:**
+
+```bash
+cordova plugin remove cordova-plugin-media
+cordova plugin add cordova-plugin-media@6.1.0
+```
+
+## Release Highlights
+
+For Android, we updated the media error response object to include the "message" property. This property will provide additional information about the error. It also syncs in line with the media error response object that iOS returns.
+
+For iOS, file scheme support has been implemented. Two fixes were applied to prevent crashes that occured when fetching the position while the time was not defined and to ensured that the category was defined after the recording was released.
+
+Please report any issues you find at [issues.cordova.io](http://issues.cordova.io/)!
Review Comment:
```suggestion
Please report any issues you find by following the this [How to File a Bug](https://github.com/apache/cordova#filing-a-bug) guide!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu merged pull request #1260: blog: media plugin 6.1.0 release
Posted by GitBox <gi...@apache.org>.
erisu merged PR #1260:
URL: https://github.com/apache/cordova-docs/pull/1260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org