You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by sanjaypujare <gi...@git.apache.org> on 2016/08/08 19:50:26 UTC
[GitHub] apex-malhar pull request #362: JMS Input operator changes to support SQS and...
GitHub user sanjaypujare opened a pull request:
https://github.com/apache/apex-malhar/pull/362
JMS Input operator changes to support SQS and ActiveMQ
@PramodSSImmaneni these changes incorporate your comments and dont have extraneous changes. Pls review and merge...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjaypujare/apex-malhar APEXMALHAR-2156.improvement2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit db32f40858ef37356b6fec836df605acdbcbcbfa
Author: Sanjay Pujare <sa...@sanjay-dt-macbook-pro.local>
Date: 2016-08-08T19:40:05Z
JMS Input operator changes to support SQS and ActiveMQ
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #362: JMS Input operator changes to support SQS and...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/362#discussion_r74064012
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -129,12 +281,22 @@ public void setConnectionFactoryClass(String connectionFactoryClass)
*/
public Map<String, String> getConnectionFactoryProperties()
{
- return connectionFactoryProperties;
+ DefaultConnectionFactoryBuilder builder =
--- End diff --
This method should also behave like getConnectionFactoryClass, throw Unsupported exception and not create a default factory builder as it is a getter. The convenience methods below setUser etc may not be able to use this method then but their functionality is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #362: JMS Input operator changes to support SQS and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/apex-malhar/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---