You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Eduardo Tsen (JIRA)" <ji...@apache.org> on 2010/09/07 15:14:32 UTC

[jira] Created: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

No FrameworkEvent.ERROR on unchecked exception in event listener
----------------------------------------------------------------

                 Key: FELIX-2584
                 URL: https://issues.apache.org/jira/browse/FELIX-2584
             Project: Felix
          Issue Type: Bug
          Components: Framework
    Affects Versions: framework-3.0.2
            Reporter: Eduardo Tsen


The OSGi-Spec states on page 116:

"The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."

The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2584:
-----------------------------------

    Fix Version/s: framework-3.2.0

> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>             Fix For: framework-3.2.0
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall resolved FELIX-2584.
------------------------------------

      Assignee: Richard S. Hall
    Resolution: Fixed

Committed a patch to trunk, please close if satisfied. Thanks.

> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>            Assignee: Richard S. Hall
>             Fix For: framework-3.2.0
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Eduardo Tsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eduardo Tsen closed FELIX-2584.
-------------------------------


> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>            Assignee: Richard S. Hall
>             Fix For: framework-3.2.0
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Eduardo Tsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915784#action_12915784 ] 

Eduardo Tsen commented on FELIX-2584:
-------------------------------------

The code changes seem fine.

I'm not sure about the logging strategy, since FrameworkEvents should be mapped by a logging service.

Thank you for the patch.

> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>            Assignee: Richard S. Hall
>             Fix For: framework-3.2.0
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2584:
-----------------------------------

    Fix Version/s: framework-3.0.4
                       (was: framework-3.2.0)

> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>            Assignee: Richard S. Hall
>             Fix For: framework-3.0.4
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915788#action_12915788 ] 

Richard S. Hall commented on FELIX-2584:
----------------------------------------

Not sure what you mean by "FrameworkEvents should be mapped by a logging service"... If there is no logging service or no framework listeners, then failures would go unlogged. It seems reasonable to log them. The framework has no way of knowing if there is someone out there listening to events and relaying the ERROR events to anyone, so it doesn't make sense just to swallow them.

> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>            Assignee: Richard S. Hall
>             Fix For: framework-3.2.0
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2584) No FrameworkEvent.ERROR on unchecked exception in event listener

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-2584:
-----------------------------------

    Component/s: Specification compliance

> No FrameworkEvent.ERROR on unchecked exception in event listener
> ----------------------------------------------------------------
>
>                 Key: FELIX-2584
>                 URL: https://issues.apache.org/jira/browse/FELIX-2584
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>    Affects Versions: framework-3.0.2
>            Reporter: Eduardo Tsen
>             Fix For: framework-3.2.0
>
>
> The OSGi-Spec states on page 116:
> "The Framework must publish a FrameworkEvent.ERROR if a callback to an event listener generates an unchecked exception - except when the callback happens while delivering a FrameworkEvent.ERROR (to prevent an infinite loop)."
> The EventDispatcher, in contrast, just logs those exceptions with no further action taken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.