Bug 16429: Align the code base with checkstyle

[Mike Bowler <mb...@GargoyleSoftware.com>]

Another patch for the style changes is attached to the bug report 
("round3").

http://issues.apache.org/bugzilla/show_bug.cgi?id=16429

There were a couple of spots where checkstyle was warning about public 
static variables.  I've created new variables that conform to our 
standards and deprecated the old ones.

I didn't want to remove the old ones at this point because they are 
public and removing them could break code that uses httpclient.  Do we 
have a schedule for removing deprecated things?

There are also some protected instance variables that I've left alone 
for the same reasons.  I didn't deprecate these as I haven't provided 
replacements.

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mbowler@GargoyleSoftware.com
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: Bug 16429: Align the code base with checkstyle

[Jeffrey Dever <js...@sympatico.ca>]

Ha, ha.  When I committed round 4 the commit message was rejected 
because it was longer than 100kB.  Thats a BIG patch.


Mike Bowler wrote:

> Another patch for the style changes is attached to the bug report 
> ("round3").
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=16429
>
> There were a couple of spots where checkstyle was warning about public 
> static variables.  I've created new variables that conform to our 
> standards and deprecated the old ones.
>
> I didn't want to remove the old ones at this point because they are 
> public and removing them could break code that uses httpclient.  Do we 
> have a schedule for removing deprecated things?
>
> There are also some protected instance variables that I've left alone 
> for the same reasons.  I didn't deprecate these as I haven't provided 
> replacements.
>