You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wido <gi...@git.apache.org> on 2016/09/15 10:24:49 UTC
[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1673
CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector
Both host and path could have been NULL which causes the StatsCollector
no to start properly.
By checking if the Strings are not Empty or Null we make sure the StatsCollector
always runs and does not prevent the Management Server from starting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wido/cloudstack CLOUDSTACK-9071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1673
----
commit 11357259b1775e80afe6724b5dac2619587bb9d5
Author: Wido den Hollander <wi...@widodh.nl>
Date: 2016-09-15T10:18:21Z
CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector
Both host and path could have been NULL which causes the StatsCollector
no to start properly.
By checking if the Strings are not Empty or Null we make sure the StatsCollector
always runs and does not prevent the Management Server from starting.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....
Posted by wido <gi...@git.apache.org>.
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@jburwell Ah, that went wrong with the rebase. Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1673
This one has two LGTMs, I think we can merge it in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido the Travis and Jenkins are failing due a compilation error. It appears to be that `StringUtils` has not been imported into `StatsCollector`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1673
Done @jburwell, it's against the 4.8 branch now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....
Posted by wido <gi...@git.apache.org>.
GitHub user wido reopened a pull request:
https://github.com/apache/cloudstack/pull/1673
CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector
Both host and path could have been NULL which causes the StatsCollector
no to start properly.
By checking if the Strings are not Empty or Null we make sure the StatsCollector
always runs and does not prevent the Management Server from starting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wido/cloudstack CLOUDSTACK-9071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1673
----
commit f95022153506a03b3eed572f6b7cc978cad0f315
Author: Wido den Hollander <wi...@widodh.nl>
Date: 2016-09-15T10:18:21Z
CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector
Both host and path could have been NULL which causes the StatsCollector
no to start properly.
By checking if the Strings are not Empty or Null we make sure the StatsCollector
always runs and does not prevent the Management Server from starting.
Conflicts:
server/src/com/cloud/server/StatsCollector.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1673
Ok @jburwell , understood. I highly doubt they are related, but OK.
Just want to make sure this small fix makes it into our next point releases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by murali-reddy <gi...@git.apache.org>.
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@jburwell failures are redundant VPC related being tracked CLOUDSTACK-9541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido sorry for the delayed response -- I lost track of this browser tab. The quickest way may be to create a new branch from 4.8, cherry pick this commit into it, push the new branch, and open a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido we are seeing these errors on other PRs. Based on the fact that they are occurring on other PRs and change does not impact these tests, I am LGTM for tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido thank you for re-targeting the PR. Do you think running the smoke tests against one of the hypervisors is sufficient to verify this defect? Should we update a Marvin test to cover it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1673
LGTM. @blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1673#discussion_r79302819
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -285,9 +286,15 @@ private void init(Map<String, String> configs) {
s_logger.info(scheme + " is not a valid protocol for external statistics. No statistics will be send.");
}
- externalStatsHost = uri.getHost();
+ if (!StringUtils.isEmpty(uri.getHost())) {
+ externalStatsHost = uri.getHost();
+ }
+
externalStatsPort = uri.getPort();
- externalStatsPrefix = uri.getPath().substring(1);
+
+ if (!StringUtils.isEmpty(uri.getPath())) {
+ externalStatsPrefix = uri.getPath().substring(1);
+ }
/* Append a dot (.) to the prefix if it is set */
if (externalStatsPrefix != null && !externalStatsPrefix.equals("")) {
--- End diff --
I realize it's not in the scope of this PR, but would you consider changing this `if` block to use `StringUtils.isEmpty`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@jburwell a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1673
<b>Trillian test result (tid-230)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26194 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1673-t230-kvm-centos7.zip
Test completed. 41 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 853.48 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 358.79 | test_vpc_redundant.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | Success | 159.81 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 297.63 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 580.58 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 523.76 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1418.20 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 537.63 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.67 | test_volumes.py
test_08_resize_volume | Success | 15.33 | test_volumes.py
test_07_resize_fail | Success | 20.46 | test_volumes.py
test_06_download_detached_volume | Success | 15.27 | test_volumes.py
test_05_detach_volume | Success | 100.23 | test_volumes.py
test_04_delete_attached_volume | Success | 10.30 | test_volumes.py
test_03_download_attached_volume | Success | 15.24 | test_volumes.py
test_02_attach_volume | Success | 43.61 | test_volumes.py
test_01_create_volume | Success | 620.83 | test_volumes.py
test_deploy_vm_multiple | Success | 272.90 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.01 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.81 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 185.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.82 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.08 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.69 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.71 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.15 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.25 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 106.03 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.14 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 40.71 | test_templates.py
test_10_destroy_cpvm | Success | 161.34 | test_ssvm.py
test_09_destroy_ssvm | Success | 132.99 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.25 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.08 | test_ssvm.py
test_06_stop_cpvm | Success | 131.37 | test_ssvm.py
test_05_stop_ssvm | Success | 143.15 | test_ssvm.py
test_04_cpvm_internals | Success | 1.31 | test_ssvm.py
test_03_ssvm_internals | Success | 6.71 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.10 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.00 | test_snapshots.py
test_04_change_offering_small | Success | 209.51 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
test_09_reboot_router | Success | 35.27 | test_routers.py
test_08_start_router | Success | 25.20 | test_routers.py
test_07_stop_router | Success | 10.14 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.51 | test_routers.py
test_03_restart_network_cleanup | Success | 50.35 | test_routers.py
test_02_router_internal_adv | Success | 0.83 | test_routers.py
test_01_router_internal_basic | Success | 0.49 | test_routers.py
test_router_dhcphosts | Success | 276.10 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.09 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 160.98 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.15 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.30 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 460.27 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 470.26 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 344.74 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 87.29 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.83 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 10.31 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.62 | test_portable_publicip.py
test_isolate_network_password_server | Success | 58.87 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.11 | test_over_provisioning.py
test_extendPhysicalNetworkVlan | Success | 15.26 | test_non_contigiousvlan.py
test_01_nic | Success | 785.92 | test_nic.py
test_releaseIP | Success | 172.69 | test_network.py
test_reboot_router | Success | 398.48 | test_network.py
test_public_ip_user_account | Success | 10.27 | test_network.py
test_public_ip_admin_account | Success | 40.32 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.54 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.61 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 123.34 | test_network.py
test_delete_account | Success | 257.69 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.57 | test_network.py
test_01_port_fwd_on_src_nat | Success | 108.80 | test_network.py
test_nic_secondaryip_add_remove | Success | 218.41 | test_multipleips_per_nic.py
login_test_saml_user | Success | 22.54 | test_login.py
test_assign_and_removal_lb | Success | 133.22 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 186.99 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 217.40 | test_loadbalance.py
test_07_list_default_iso | Success | 0.04 | test_iso.py
test_05_iso_permissions | Success | 0.04 | test_iso.py
test_04_extract_Iso | Success | 5.14 | test_iso.py
test_03_delete_iso | Success | 95.18 | test_iso.py
test_02_edit_iso | Success | 0.04 | test_iso.py
test_01_create_iso | Success | 21.27 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 222.84 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 182.53 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 560.30 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 453.76 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.35 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.22 | test_global_settings.py
test_04_create_fat_type_disk_offering | Success | 0.04 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.04 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 15.38 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.45 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 76.02 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.28 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 75.69 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.33 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.21 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 228.33 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 192.77 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 80.86 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@jburwell You need to configure the management server with Graphite enabled with a wrongly entered URI to trigger this bug.
This is a manual error when somebody gives in a wrongly formed URL. The Graphite output was not broken by default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido there are two errors related to template download in the blueorganutan run that we need to explain before merging this PR. We are seeing a similar issue on #1587. @abhinandanprateek and @murali-reddy are looking into the failures. Hopefully, we will have an explanation/fix shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1673
The test results have some intermittent failures around VPC VR related tests. The PR does not break anything, LGTM on both tests and code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1673#discussion_r79316781
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -285,9 +286,15 @@ private void init(Map<String, String> configs) {
s_logger.info(scheme + " is not a valid protocol for external statistics. No statistics will be send.");
--- End diff --
I realize it is out of scope for this PR, but would mind changing the log level to ``WARN`` for this message? It is clearly a user intent that is not going to be carried through due to bad configuration data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@wido this fix seems like it would be good for 4.8 and 4.9 as well. Would you mind re-pointing this PR to the 4.8 branch?
Also, could you investigate the cause of the Jenkins failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1673
@jburwell I've done that, that if now also uses StringUtils.
What is the easiest way to point this against 4.8? Changing the base on Github breaks everything and rebasing locally against 4.8 it does the same.
My git-foo isn't that good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1673
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---