You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by mc...@apache.org on 2021/06/01 07:19:54 UTC

[incubator-hop] branch master updated: HOP-2921 : SWT Error while running unit tests

This is an automated email from the ASF dual-hosted git repository.

mcasters pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hop.git


The following commit(s) were added to refs/heads/master by this push:
     new defea94  HOP-2921 : SWT Error while running unit tests
     new e39748a  Merge pull request #837 from mattcasters/master
defea94 is described below

commit defea942e57829465732a8a84bc6ccc35da63e16
Author: Matt Casters <ma...@gmail.com>
AuthorDate: Tue Jun 1 09:18:44 2021 +0200

    HOP-2921 : SWT Error while running unit tests
---
 .../hop/testing/xp/ValidatePipelineUnitTestExtensionPoint.java   | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/ValidatePipelineUnitTestExtensionPoint.java b/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/ValidatePipelineUnitTestExtensionPoint.java
index 8cf52dc..6f75071 100644
--- a/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/ValidatePipelineUnitTestExtensionPoint.java
+++ b/plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/ValidatePipelineUnitTestExtensionPoint.java
@@ -97,10 +97,11 @@ public class ValidatePipelineUnitTestExtensionPoint
 
         String dontShowResults =
             pipeline.getVariable(DataSetConst.VAR_DO_NOT_SHOW_UNIT_TEST_ERRORS, "N");
-
-        final HopGui hopGui = HopGui.getInstance();
-        if (hopGui != null && "N".equalsIgnoreCase(dontShowResults)) {
-          showUnitTestErrors(pipeline, results, hopGui);
+        if ("N".equalsIgnoreCase(dontShowResults)) {
+          final HopGui hopGui = HopGui.getInstance();
+          if (hopGui != null) {
+            showUnitTestErrors(pipeline, results, hopGui);
+          }
         }
       }
       log.logBasic("----------------------------------------------");