You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/23 02:19:25 UTC

[GitHub] [airflow] mlgruby edited a comment on issue #14363: Argument order change in airflow.providers.google.cloud.hooks.gcs.GCSHook:download appears to be a mistake.

mlgruby edited a comment on issue #14363:
URL: https://github.com/apache/airflow/issues/14363#issuecomment-783816698


   Yes, the swap was done on purpose as there is no default value for object_name and to make mypy pass this check I have to put the no default argument at first and then the default value arguments ones. 
   
   Agree that the doc block is not updated, My Bad. I make the changes to doc block and also make changes to upload and delete so that all three functions can have the same order of arguments. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org