You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/08/14 04:10:15 UTC
Review Request 13550: Added 5 missing tests from the QA repo to
test_custom_hostname.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13550/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Added 5 missing tests from the QA repo to test_custom_hostname.py in the ASF repo
Diffs
-----
test/integration/component/test_accounts.py cf18bef
test/integration/component/test_custom_hostname.py 0898e1e
Diff: https://reviews.apache.org/r/13550/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 13550: Added 5 missing tests from the QA repo to
test_custom_hostname.py
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13550/#review25212
-----------------------------------------------------------
Ship it!
applied with changes to git summary. please use a meaningful summary next time.
- Prasanna Santhanam
On Aug. 15, 2013, 3 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13550/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 3 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added 5 missing tests from the QA repo to test_custom_hostname.py in the ASF repo
>
>
> Diffs
> -----
>
> test/integration/component/test_custom_hostname.py 0898e1e
>
> Diff: https://reviews.apache.org/r/13550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13550: Added 5 missing tests from the QA repo to
test_custom_hostname.py
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13550/
-----------------------------------------------------------
(Updated Aug. 15, 2013, 3 a.m.)
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Changes
-------
Removed changes for test_accounts from this diff -> Updated diff for test_accounts with review comments and removed invalid test from there.
Repository: cloudstack-git
Description
-------
Added 5 missing tests from the QA repo to test_custom_hostname.py in the ASF repo
Diffs (updated)
-----
test/integration/component/test_custom_hostname.py 0898e1e
Diff: https://reviews.apache.org/r/13550/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 13550: Added 5 missing tests from the QA repo to
test_custom_hostname.py
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13550/#review25119
-----------------------------------------------------------
Review 13550 failed the build test : UNSTABLE
The url of build cloudstack-master-with-patch #126 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/126/
- Jenkins Cloudstack.org
On Aug. 14, 2013, 2:10 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13550/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 2:10 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added 5 missing tests from the QA repo to test_custom_hostname.py in the ASF repo
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py cf18bef
> test/integration/component/test_custom_hostname.py 0898e1e
>
> Diff: https://reviews.apache.org/r/13550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13550: Added 5 missing tests from the QA repo to
test_custom_hostname.py
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13550/#review25137
-----------------------------------------------------------
test/integration/component/test_accounts.py
<https://reviews.apache.org/r/13550/#comment49364>
This test is invalid. It was removed
See: http://markmail.org/message/vk7wyl3b57cltj44
- Prasanna Santhanam
On Aug. 14, 2013, 2:10 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13550/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 2:10 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added 5 missing tests from the QA repo to test_custom_hostname.py in the ASF repo
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py cf18bef
> test/integration/component/test_custom_hostname.py 0898e1e
>
> Diff: https://reviews.apache.org/r/13550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>