[GitHub] [yunikorn-scheduler-interface] craigcondit commented on a diff in pull request #67: [YUNIKORN-1222] [SI] preempt pods based on the priorities

[GitBox <gi...@apache.org>]

craigcondit commented on code in PR #67:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/67#discussion_r882873975


##########
scheduler-interface-spec.md:
##########
@@ -447,6 +447,8 @@ message AllocationAsk {
   // Is this a placeholder ask (true) or a real ask (false), defaults to false
   // ignored if the taskGroupName is not set
   bool placeholder = 10;
+  // Does this ask originates the application?

Review Comment:
   Grammar: should be `Is this ask the originator of the application?`



##########
scheduler-interface-spec.md:
##########
@@ -714,6 +716,7 @@ const (
 	KeyPodName      = "podName"
 	KeyNamespace    = "namespace"
 	KeyRequiredNode = "requiredNode"
+	KeyAllowPreemption = "allowPreemption"

Review Comment:
   Update spacing of this block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org