You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/05/21 10:01:58 UTC
[Impala-ASF-CR] IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24339
Change subject: IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
......................................................................
IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
IcebergDeleteBuilder::Prepare() does some time-consuming work, e.g.
it builds maps based on the assigned data files, and read Iceberg V3
deletion vectors.
With this patch we track its duration in profile->total_time_counter.
Testing
* tested manually that Summary contains the correct elapsed time
for the build fragment.
Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
---
M be/src/exec/iceberg-delete-builder.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/24339/1
--
To view, visit http://gerrit.cloudera.org:8080/24339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24339 )
Change subject: IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
......................................................................
IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
IcebergDeleteBuilder::Prepare() does some time-consuming work, e.g.
it builds maps based on the assigned data files, and read Iceberg V3
deletion vectors.
With this patch we track its duration in profile->total_time_counter.
Testing
* tested manually that Summary contains the correct elapsed time
for the build fragment.
Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Reviewed-on: http://gerrit.cloudera.org:8080/24339
Reviewed-by: Peter Rozsa <pr...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/iceberg-delete-builder.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Peter Rozsa: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24339 )
Change subject: IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22567/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 10:26:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24339 )
Change subject: IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 15:56:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24339 )
Change subject: IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13527/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 11:22:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24339 )
Change subject: IMPALA-15031: Measure total time in IcebergDeleteBuilder::Prepare()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eb81d3178a128a78b077c4369fdcfe46c19e36a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 11:30:17 +0000
Gerrit-HasComments: No