You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/12/02 02:37:54 UTC

Review Request 28592: Alerts: Upgrade Should Remove Nagios If Installed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28592/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-8502
    https://issues.apache.org/jira/browse/AMBARI-8502


Repository: ambari


Description
-------

On upgrading to Ambari 2.0.0, Nagios should be removed from all clusters defined in Ambari. 

1) Install Ambari 1.7.0 with a cluster that has Nagios
2) Perform Upgrade to Ambari 2.0.0
3) Verify that Nagios is removed and that the new alerts framework has taken over correctly.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 57840d4 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 004d213 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java d053d83 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java d456101 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 1545a03 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java PRE-CREATION 

Diff: https://reviews.apache.org/r/28592/diff/


Testing
-------

Installed a 1.7.0 cluster with Nagios and then performed the database upgrade. Started Ambari after the upgrade and verified that Nagio has been removed from the host, and as a service from the cluster.

New tests added to verify removal of Nagios during 2.0.0 DML update.


Thanks,

Jonathan Hurley


Re: Review Request 28592: Alerts: Upgrade Should Remove Nagios If Installed

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28592/#review63490
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Dec. 2, 2014, 1:37 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28592/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 1:37 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-8502
>     https://issues.apache.org/jira/browse/AMBARI-8502
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On upgrading to Ambari 2.0.0, Nagios should be removed from all clusters defined in Ambari. 
> 
> 1) Install Ambari 1.7.0 with a cluster that has Nagios
> 2) Perform Upgrade to Ambari 2.0.0
> 3) Verify that Nagios is removed and that the new alerts framework has taken over correctly.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 57840d4 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 004d213 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java d053d83 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java d456101 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 1545a03 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28592/diff/
> 
> 
> Testing
> -------
> 
> Installed a 1.7.0 cluster with Nagios and then performed the database upgrade. Started Ambari after the upgrade and verified that Nagio has been removed from the host, and as a service from the cluster.
> 
> New tests added to verify removal of Nagios during 2.0.0 DML update.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 28592: Alerts: Upgrade Should Remove Nagios If Installed

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28592/#review63541
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 1, 2014, 8:37 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28592/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 8:37 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-8502
>     https://issues.apache.org/jira/browse/AMBARI-8502
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On upgrading to Ambari 2.0.0, Nagios should be removed from all clusters defined in Ambari. 
> 
> 1) Install Ambari 1.7.0 with a cluster that has Nagios
> 2) Perform Upgrade to Ambari 2.0.0
> 3) Verify that Nagios is removed and that the new alerts framework has taken over correctly.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 57840d4 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 004d213 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java d053d83 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java d456101 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 1545a03 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28592/diff/
> 
> 
> Testing
> -------
> 
> Installed a 1.7.0 cluster with Nagios and then performed the database upgrade. Started Ambari after the upgrade and verified that Nagio has been removed from the host, and as a service from the cluster.
> 
> New tests added to verify removal of Nagios during 2.0.0 DML update.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>