You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/04/26 04:17:50 UTC

[jira] Created: (HADOOP-6724) IPC doesn't properly handle IOEs thrown by socket factory

IPC doesn't properly handle IOEs thrown by socket factory
---------------------------------------------------------

                 Key: HADOOP-6724
                 URL: https://issues.apache.org/jira/browse/HADOOP-6724
             Project: Hadoop Common
          Issue Type: Bug
          Components: ipc
    Affects Versions: 0.20.3, 0.21.0, 0.22.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon


If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HADOOP-6724) IPC doesn't properly handle IOEs thrown by socket factory

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins resolved HADOOP-6724.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
                   0.20.3

I ran test-patch and committed this to branch 20.

> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
>                 Key: HADOOP-6724
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6724
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.20.3, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.20.3, 0.22.0, 0.21.0
>
>         Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-6724) IPC doesn't properly handle IOEs thrown by socket factory

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon reopened HADOOP-6724:
---------------------------------


Think we should commit this to branch-20 as well. It's pretty nasty and a simple fix.

> IPC doesn't properly handle IOEs thrown by socket factory
> ---------------------------------------------------------
>
>                 Key: HADOOP-6724
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6724
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.20.3, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.21.0
>
>         Attachments: hadoop-6724-20-1.patch, hadoop-6724.txt
>
>
> If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.