[GitHub] [tinkerpop] spmallette commented on a change in pull request #1105: TINKERPOP-2205 Change connection management to single request per channel

[GitBox <gi...@apache.org>]

spmallette commented on a change in pull request #1105: TINKERPOP-2205 Change connection management to single request per channel
URL: https://github.com/apache/tinkerpop/pull/1105#discussion_r292166997
 
 

 ##########
 File path: gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
 ##########
 @@ -65,34 +76,43 @@
     public void close(final Channel channel);
 
     /**
-     * Create a message for the driver to use as a "keep-alive" for the connection. This method will only be used if
+     * Create a message for the driver to use as a "keep-alive" for the connectionPool. This method will only be used if
      * {@link #supportsKeepAlive()} is {@code true}.
+     *
+     * This method will be deprecated in future. Keep-alive is implemented using Netty ping-pong mechanism.
+     * See {@link WebSocketIdleEventHandler}
      */
+    @Deprecated
 
 Review comment:
   after thinking on this for a bit, let's not deprecate this method until we specifically want to close down the entire abstraction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services