You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/07 17:54:13 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #38537: [WIP][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
MaxGekk opened a new pull request, #38537:
URL: https://github.com/apache/spark/pull/38537
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016755129
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
Not sure about this. For me, it means columns that contains numbers. If `NUM` comes first, it should `NUM_OF_COLUMNS_MISMATCH`, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
srielau commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016774095
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
Here is the pattern have used throughout my career: for (colNum = 0; colNum < numCols; colNum++).
I have no objection to NUM_OF_COLUMNS_MISMATCH or NUMBER_OF_COLUMNS_MISMATCH. The error-class name is not too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016783019
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
ok. I will rename it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016759785
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
ok. I am not a native speaker. For me, your proposal look slightly weird. @srielau Just wonder, how would you say: columns that contain numbers using two words :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `NUM_COLUMNS_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `NUM_COLUMNS_MISMATCH`
URL: https://github.com/apache/spark/pull/38537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
srielau commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016742349
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
This sounds unnecessarily awkward... How about;
```suggestion
"NUM_COLUMNNS_MISMATCH" : {
```
##########
sql/core/src/test/resources/sql-tests/results/except-all.sql.out:
##########
@@ -228,12 +228,12 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "_LEGACY_ERROR_TEMP_2429",
+ "errorClass" : "COLUMNS_NUM_MISMATCH",
"messageParameters" : {
- "firstColNum" : "1",
- "nColNum" : "2",
- "nTab" : "second",
- "operator" : "ExceptAll"
+ "invalidColumnsNum" : "2",
+ "invalidOrdinalNum" : "second",
+ "operator" : "EXCEPTALL",
+ "refColumnsNum" : "1"
Review Comment:
```suggestion
"invalidNumColumns" : "2",
"invalidOrdinalNum" : "second",
"operator" : "EXCEPTALL",
"refNumColumns" : "1"
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -541,12 +541,12 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
// Check the number of columns
if (child.output.length != ref.length) {
e.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2429",
+ errorClass = "COLUMNS_NUM_MISMATCH",
Review Comment:
```suggestion
errorClass = "NUM_COLUMNS_MISMATCH",
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
+ "message" : [
+ "<operator> can only be performed on tables with the same number of columns, but the first table has <refColumnsNum> columns and the <invalidOrdinalNum> table has <invalidColumnsNum> columns."
Review Comment:
```suggestion
"<operator> can only be performed on tables with the same number of columns, but the first table has <refNumColumns> columns and the <invalidOrdinalNum> table has <invalidNumColumns> columns."
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -541,12 +541,12 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
// Check the number of columns
if (child.output.length != ref.length) {
e.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2429",
+ errorClass = "COLUMNS_NUM_MISMATCH",
messageParameters = Map(
- "operator" -> operator.nodeName,
- "firstColNum" -> ref.length.toString,
- "nTab" -> ordinalNumber(ti + 1),
- "nColNum" -> child.output.length.toString))
+ "operator" -> toSQLStmt(operator.nodeName),
+ "refColumnsNum" -> ref.length.toString,
+ "invalidOrdinalNum" -> ordinalNumber(ti + 1),
+ "invalidColumnsNum" -> child.output.length.toString))
Review Comment:
```suggestion
"refNumColumns" -> ref.length.toString,
"invalidOrdinalNum" -> ordinalNumber(ti + 1),
"invalidNumColumns" -> child.output.length.toString))
```
##########
sql/core/src/test/resources/sql-tests/results/except-all.sql.out:
##########
@@ -228,12 +228,12 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "_LEGACY_ERROR_TEMP_2429",
+ "errorClass" : "COLUMNS_NUM_MISMATCH",
Review Comment:
```suggestion
"errorClass" : "NUM_COLUMNS_MISMATCH",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016759785
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
ok. I am not a native speaker. For me, your proposal look slightly weird to me. @srielau Just wonder, how would you say: columns that contain numbers using two words :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38537:
URL: https://github.com/apache/spark/pull/38537#issuecomment-1306921664
@cloud-fan @srielau @itholic @LuciferYang @panbingkun Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `NUM_COLUMNS_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38537:
URL: https://github.com/apache/spark/pull/38537#issuecomment-1307785068
Merging to master. All GAs passed.
Thank you, @srielau @cloud-fan @LuciferYang for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016748273
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
`NUM_COLUMNS_MISMATCH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38537: [SPARK-41043][SQL] Rename the error class `_LEGACY_ERROR_TEMP_2429` to `COLUMNS_NUM_MISMATCH`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38537:
URL: https://github.com/apache/spark/pull/38537#discussion_r1016755129
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -94,6 +94,11 @@
],
"sqlState" : "22005"
},
+ "COLUMNS_NUM_MISMATCH" : {
Review Comment:
Not sure about this. For me, it means columns that contains numbers but columns number. If `NUM` comes first, it should `NUM_OF_COLUMNS_MISMATCH`, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org