You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "thetumbled (via GitHub)" <gi...@apache.org> on 2024/07/09 03:57:14 UTC

Re: [PR] [improve][authentication] Pass the authorization when user lookup transactionCoordinator topic [pulsar]

thetumbled commented on code in PR #22744:
URL: https://github.com/apache/pulsar/pull/22744#discussion_r1669646548


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java:
##########
@@ -155,6 +156,9 @@ public CompletableFuture<Boolean> canConsumeAsync(TopicName topicName, String ro
     @Override
     public CompletableFuture<Boolean> canLookupAsync(TopicName topicName, String role,
             AuthenticationDataSource authenticationData) {
+        if (SystemTopicNames.isTransactionCoordinatorAssign(topicName)) {

Review Comment:
   Why should we implement it in `AuthenticationService`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org