You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sateesh-chodapuneedi <gi...@git.apache.org> on 2016/12/20 15:04:59 UTC
[GitHub] cloudstack pull request #1841: CLOUDSTACK-9684 Invalid zone id error while l...
GitHub user sateesh-chodapuneedi opened a pull request:
https://github.com/apache/cloudstack/pull/1841
CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=====
While listing datacenters associated with a zone, only zone Id validation is required.
There is no need to have additional checks like zone is a legacy zone or not.
Fix
===
Removed unnecessary checks over zone ID and just checking if zone with specified ID exists or not.
Signed-off-by: Sateesh Chodapuneedi <sa...@accelerite.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sateesh-chodapuneedi/cloudstack pr-cloudstack-9684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1841
----
commit 870c2f59b476276475d2c8c711f2aa116ab70a45
Author: Sateesh Chodapuneedi <sa...@accelerite.com>
Date: 2016-12-20T02:15:26Z
CLOUDSTACK-9684 Invalid zone id error while listing vmware zone
Issue
=====
While listing datacenters associated with a zone, only zone Id validation is required.
There is no need to have additional checks like zone is a legacy zone or not.
Fix
===
Removed unnecessary checks over zone ID and just checking if zone with specified ID exists or not.
Signed-off-by: Sateesh Chodapuneedi <sa...@accelerite.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1841
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1841: CLOUDSTACK-9684 Invalid zone id error while l...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1841#discussion_r103883712
--- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java ---
@@ -1180,10 +1180,7 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
private void validateZone(Long zoneId) throws InvalidParameterValueException {
--- End diff --
No, this method is being used in other part of code. This method does more than zone existence check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1841
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1841
Thanks @sureshanaparti
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1841
<b>Trillian test result (tid-861)</b>
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43746 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1841-t861-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 788.65 | test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 70.86 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 75.94 | test_snapshots.py
ContextSuite context=TestSnapshotRootDisk>:teardown | `Error` | 101.23 | test_snapshots.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 817.80 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 848.20 | test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 332.24 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 182.45 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 549.91 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 335.12 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 666.47 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 581.68 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1529.06 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 669.18 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 614.34 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1300.01 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.84 | test_volumes.py
test_06_download_detached_volume | Success | 45.47 | test_volumes.py
test_05_detach_volume | Success | 100.27 | test_volumes.py
test_04_delete_attached_volume | Success | 10.20 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 49.27 | test_volumes.py
test_01_create_volume | Success | 505.66 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 496.97 | test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 222.17 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 136.18 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.64 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 252.74 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 55.97 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.13 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.14 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.29 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.14 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 191.32 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 10.18 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.19 | test_templates.py
test_01_create_template | Success | 91.26 | test_templates.py
test_10_destroy_cpvm | Success | 211.82 | test_ssvm.py
test_09_destroy_ssvm | Success | 233.76 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.64 | test_ssvm.py
test_07_reboot_ssvm | Success | 188.58 | test_ssvm.py
test_06_stop_cpvm | Success | 171.95 | test_ssvm.py
test_05_stop_ssvm | Success | 268.73 | test_ssvm.py
test_04_cpvm_internals | Success | 1.22 | test_ssvm.py
test_03_ssvm_internals | Success | 3.54 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.12 | test_snapshots.py
test_04_change_offering_small | Success | 121.86 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 120.87 | test_routers.py
test_08_start_router | Success | 95.69 | test_routers.py
test_07_stop_router | Success | 20.26 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.65 | test_routers.py
test_03_restart_network_cleanup | Success | 115.96 | test_routers.py
test_02_router_internal_adv | Success | 1.01 | test_routers.py
test_01_router_internal_basic | Success | 0.53 | test_routers.py
test_router_dns_guestipquery | Success | 76.77 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py
test_router_dhcphosts | Success | 105.70 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.60 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.08 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 45.54 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.20 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.41 | test_public_ip_range.py
test_02_vpc_privategw_static_routes | Success | 636.78 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 167.71 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.94 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.18 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.48 | test_portable_publicip.py
test_isolate_network_password_server | Success | 97.22 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.15 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.91 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.33 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.24 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.32 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.31 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.33 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.31 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.42 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 93.04 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.19 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.16 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.41 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.37 | test_non_contigiousvlan.py
test_01_nic | Success | 379.25 | test_nic.py
test_releaseIP | Success | 288.13 | test_network.py
test_reboot_router | Success | 610.23 | test_network.py
test_public_ip_user_account | Success | 10.26 | test_network.py
test_public_ip_admin_account | Success | 40.29 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.81 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.62 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.30 | test_network.py
test_delete_account | Success | 328.14 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.73 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.94 | test_network.py
test_nested_virtualization_vmware | Success | 258.47 | test_nested_virtualization.py
test_nic_secondaryip_add_remove | Success | 152.26 | test_multipleips_per_nic.py
login_test_saml_user | Success | 19.18 | test_login.py
test_assign_and_removal_lb | Success | 148.03 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 202.02 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 207.66 | test_loadbalance.py
test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.06 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.13 | test_iso.py
test_03_delete_iso | Success | 95.18 | test_iso.py
test_02_edit_iso | Success | 0.09 | test_iso.py
test_01_create_iso | Success | 21.02 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 475.45 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 344.66 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 955.03 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 737.60 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.27 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.15 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.28 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 6.02 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.87 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.93 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.99 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.92 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.02 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.92 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 10.96 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.95 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.88 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.05 | test_dynamicroles.py
test_role_account_acls | Success | 8.21 | test_dynamicroles.py
test_default_role_deletion | Success | 5.97 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 45.73 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 65.89 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 151.24 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 20.43 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 142.18 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.88 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.86 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 6.01 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 192.46 | test_deploy_vm_iso.py
test_3d_gpu_support | Success | 394.82 | test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroup | Success | 217.41 | test_affinity_groups.py
test_08_resize_volume | Skipped | 5.11 | test_volumes.py
test_07_resize_fail | Skipped | 10.28 | test_volumes.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 66.33 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 1.10 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@karuturi Checked the tests errors, they seem to be unrelated to this PR code fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1841
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@blueorangutan test centos7 vmware-60u2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@borisstoyanov Can you please run trillian tests for this PR?
This already has enough code LGTMs, and needs tests for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@sateesh-chodapuneedi can you take a look at the test failures as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1841
@karuturi I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of comma separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py, component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'murali-reddy', 'abhinandanprateek', 'PaulAngus', 'borisstoyanov']
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---