You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/14 02:22:27 UTC

[GitHub] [echarts] pissang opened a new pull request #15715: test: optimize test cases for visual regression test

pissang opened a new pull request #15715:
URL: https://github.com/apache/echarts/pull/15715


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   Optimize test cases from https://github.com/apache/echarts/pull/15599 for visual regression testing tool. To ensure:
   
   1. It needs to reflect the objectives of the test on the screenshot. For example, the animation duration needs to be long so the screenshot will be the intermediate state instead of the final state. The final state can't reflect the animation process.
   2. Every test case needs to been added at the bottom. To avoid the changed layout make recorded interactions fail.
   3. Every test case should have a title to describe the test feature.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15715: test: optimize test cases for visual regression test

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15715:
URL: https://github.com/apache/echarts/pull/15715#issuecomment-918740039


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15715: test: optimize test cases for visual regression test

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15715:
URL: https://github.com/apache/echarts/pull/15715#issuecomment-918741884


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #15715: test: optimize test cases for visual regression test

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15715:
URL: https://github.com/apache/echarts/pull/15715


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org