You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:26:32 UTC
[GitHub] [lucene-solr] gerlowskija opened a new pull request #1379:
SOLR-14363: Separate /get requests into their own type designation
gerlowskija opened a new pull request #1379: SOLR-14363: Separate /get requests into their own type designation
URL: https://github.com/apache/lucene-solr/pull/1379
# Description
The SolrLogParseTool parses most log records containing the string "QTime=" as being a query. While this is useful, the designation would be a little more helpful if operations with a different performance profile were broken out into their own "type_s" value. That gives users the ability to view them together or separately, as they prefer.
# Solution
Change the parsing code in SolrLogParseTool to check specifically for "/get" requests when parsing query requests. Other than settings "type_s" and "id_s" all other fields are handled in a way identical to other queries
# Tests
A unit test for the new "rtg" type_s value.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `ant precommit` and the appropriate test suite.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gerlowskija edited a comment on issue #1379:
SOLR-14363: Separate /get requests into their own type designation
Posted by GitBox <gi...@apache.org>.
gerlowskija edited a comment on issue #1379: SOLR-14363: Separate /get requests into their own type designation
URL: https://github.com/apache/lucene-solr/pull/1379#issuecomment-604650801
> Can we instead dynamically pull out the request handler path no matter what it is?
We do - it gets indexed into a field called `path_s`. That happens regardless of this PR. Changing the tokenization on `path_s` sounds reasonable, but is probably a separate PR since it's not entirely connected.
This PR is mostly about the `type_s` field. `type_s` gets populated with a few enum-like values that aim to represent broad classes/types of requests: "update", "query", "commit", etc. The idea is that admins can get a sense at a glance as to what sort of traffic is hitting cross sections of their cluster without getting as granular as `path_s` provides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1379: SOLR-14363:
Separate /get requests into their own type designation
Posted by GitBox <gi...@apache.org>.
dsmiley commented on issue #1379: SOLR-14363: Separate /get requests into their own type designation
URL: https://github.com/apache/lucene-solr/pull/1379#issuecomment-604038313
Can we instead dynamically pull out the request handler path no matter what it is? Then we could index this with https://builds.apache.org/job/Solr-reference-guide-master/javadoc/tokenizers.html#path-hierarchy-tokenizer or similar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gerlowskija commented on issue #1379: SOLR-14363:
Separate /get requests into their own type designation
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on issue #1379: SOLR-14363: Separate /get requests into their own type designation
URL: https://github.com/apache/lucene-solr/pull/1379#issuecomment-604650801
> Can we instead dynamically pull out the request handler path no matter what it is?
We do this already - it gets indexed into a field called `path_s`. That happens regardless of this PR. Changing the tokenization on `path_s` sounds reasonable, but is probably a separate PR since it's not entirely connected.
This PR is mostly about the `type_s` field. `type_s` gets populated with a few enum-like values that aim to represent broad classes/types of requests: "update", "query", "commit", etc. The idea is that admins can get a sense at a glance as to what sort of traffic is hitting cross sections of their cluster without getting as granular as `path_s` provides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gerlowskija merged pull request #1379: SOLR-14363:
Separate /get requests into their own type designation
Posted by GitBox <gi...@apache.org>.
gerlowskija merged pull request #1379: SOLR-14363: Separate /get requests into their own type designation
URL: https://github.com/apache/lucene-solr/pull/1379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] gerlowskija edited a comment on issue #1379:
SOLR-14363: Separate /get requests into their own type designation
Posted by GitBox <gi...@apache.org>.
gerlowskija edited a comment on issue #1379: SOLR-14363: Separate /get requests into their own type designation
URL: https://github.com/apache/lucene-solr/pull/1379#issuecomment-604650801
> Can we instead dynamically pull out the request handler path no matter what it is?
We do this already - it gets indexed into a field called `path_s`. That happens regardless of this PR. Changing the tokenization on `path_s` sounds reasonable, but is probably a separate PR since it's not entirely connected.
This PR is mostly about the `type_s` field. `type_s` gets populated with a few enum-like values that aim to represent broad classes/types of requests: "update", "query", "commit", etc. The idea is that admins can get a sense at a glance as to what sort of traffic is hitting cross sections of their cluster without getting as granular as `path_s` provides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org