[GitHub] [ozone] devmadhuu commented on a diff in pull request #4591: HDDS-8411. Show the total number of CLOSING, QUASI_CLOSED, CLOSED, DELETING Containers in Recon

["devmadhuu (via GitHub)" <gi...@apache.org>]

devmadhuu commented on code in PR #4591:
URL: https://github.com/apache/ozone/pull/4591#discussion_r1172335722


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -180,6 +196,12 @@ public Response getClusterState() {
         .setTotalDatanodes(datanodeDetails.size())
         .setHealthyDatanodes(healthyDatanodes)
         .setOpenContainers(containerStateCounts.getOpenContainersCount())
+        .setClosingContainers(containerStateCounts.getClosingContainersCount())
+        .setQuasiClosedContainers(
+            containerStateCounts.getQuasiClosedContainersCount())
+        .setClosedContainers(containerStateCounts.getClosedContainersCount())

Review Comment:
   This may not be needed, as difference of total and open will give us closed container count. Rest all information on container states can be easily found out using Ozone admin CLI because we don't want to expose the transitioning container states to other users, and should be exposed to Admin users only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org