You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "userid0x0 (via GitHub)" <gi...@apache.org> on 2023/06/02 13:53:25 UTC
[GitHub] [nuttx] userid0x0 opened a new pull request, #9465: initial FPU support for ARMv8R
userid0x0 opened a new pull request, #9465:
URL: https://github.com/apache/nuttx/pull/9465
## Summary
Initial support for floating point on ARMv8R AARCH32. Tested using ARM FVP AEMv8R configured like an CortexR52.
I skipped NEON as I am not sure about the compiler flags here.
## Impact
## Testing
`ostest` passed on ARM FVP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #9465: initial FPU support for ARMv8R AARCH32
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #9465:
URL: https://github.com/apache/nuttx/pull/9465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9465: initial FPU support for ARMv8R AARCH32
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9465:
URL: https://github.com/apache/nuttx/pull/9465#discussion_r1214625534
##########
arch/arm/src/armv8-r/arm_head.S:
##########
@@ -197,15 +197,15 @@ __cpu0_start:
bl arm_data_initialize
/* Platform hook for highest EL */
- bl arm_el_init
+ bl arm_el_init
/* Move to PL1 SYS with all exceptions masked */
Review Comment:
Please switch to TABs here also
##########
arch/arm/src/armv8-r/arm_head.S:
##########
@@ -197,15 +197,15 @@ __cpu0_start:
bl arm_data_initialize
/* Platform hook for highest EL */
Review Comment:
Please switch to TABs here also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9465: initial FPU support for ARMv8R AARCH32
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9465:
URL: https://github.com/apache/nuttx/pull/9465#discussion_r1217363292
##########
arch/arm/src/armv8-r/arm_head.S:
##########
@@ -160,7 +160,7 @@ __cpu0_start:
/* Make sure that IRQs and FIQs are disabled */
- cpsid if
+ cpsid if
Review Comment:
should we align this? @userid0x0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org