You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/27 08:04:45 UTC
[GitHub] [kafka] lkokhreidze opened a new pull request #8558: KAFKA-8611 / KIP-221 documentation
lkokhreidze opened a new pull request #8558:
URL: https://github.com/apache/kafka/pull/8558
Added KIP-221 documentation
<img width="1019" alt="Screen Shot 2020-04-27 at 11 03 43 AM" src="https://user-images.githubusercontent.com/8927925/80348679-d5a37800-8876-11ea-90a6-b5e30576efbe.png">
<img width="991" alt="Screen Shot 2020-04-27 at 10 56 37 AM" src="https://user-images.githubusercontent.com/8927925/80348684-d76d3b80-8876-11ea-98c5-b81bb9158367.png">
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lkokhreidze removed a comment on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
lkokhreidze removed a comment on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-624660155
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #8558:
URL: https://github.com/apache/kafka/pull/8558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lkokhreidze commented on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
lkokhreidze commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-624660155
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lkokhreidze commented on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
lkokhreidze commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-620101449
call for review @vvcephei @mjsax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lkokhreidze commented on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
lkokhreidze commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-629109588
Hi @mjsax
Yup, see it now. I was the victim of my own email filter and missed your email :)
I responded in the voting thread and I created ticket for it https://issues.apache.org/jira/browse/KAFKA-10003 I may have time to work on it sometime next week but if you get there sooner I won't mind at all :) so gtg from my side and thanks for the info :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lkokhreidze commented on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
lkokhreidze commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-628419029
Hi @mjsax
I've rebased the branch.
Do you mean comment by Guozhang in the voting thread? If not, I missed it and can't find anything new in the DISCUSS thread. Can you point me where was it asked?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-628314584
@lkokhreidze Did PR shows a conflict. Can you rebase it?
Btw: did you see the follow up question on the mailing list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8558: KAFKA-8611 / KIP-221 documentation
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-628812878
Yes, on the voting thread: I proposed to also deprecate `through()` via KIP-221 and Guozhang replied. But it's your KIP and I don't want to "hijack" it :) -- I am willing to do the follow up PR, if you agree on the change (I can also update the KIP itself). But won't do it without your consensus :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org