You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/08 21:00:32 UTC
[GitHub] [arrow] carols10cents opened a new pull request #8405: One definition/repetition level test
carols10cents opened a new pull request #8405:
URL: https://github.com/apache/arrow/pull/8405
Hey @nevi-me, before I go write a bunch of these, is this what would be useful for testing levels? Is there an easier way to create the arrays?
I'm basing these on [tests in the C++ implementation](https://github.com/apache/arrow/blob/4bbb74713c6883e8523eeeb5ac80a1e1f8521674/cpp/src/parquet/arrow/path_internal_test.cc) that have a nice JSON constructor, and I tried using the [JSON Reader](https://github.com/apache/arrow/blob/4bbb74713c6883e8523eeeb5ac80a1e1f8521674/rust/arrow/src/json/reader.rs) but I couldn't get what I created with the JSON Reader to what I created that I currently have here :-/
Thank you for any feedback you have!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-706557148
If you don't mind, can we keep this as a draft, so I can also add the work that I've been doing on repetitions? I've been focusing more on nested def and rep, such a headache though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] carols10cents commented on pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
carols10cents commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-717950598
I think I'm going to close this one for now; I don't think it's useful until the def/rep levels are a bit further along.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] carols10cents closed pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
carols10cents closed pull request #8405:
URL: https://github.com/apache/arrow/pull/8405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-705823515
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] carols10cents commented on pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
carols10cents commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-715588688
@nevi-me So @shepmaster and I wrote some more tests, but they're failing and we're not sure if our setup is wrong or if they're expected to fail? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-705823515
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] carols10cents commented on pull request #8405: One definition/repetition level test
Posted by GitBox <gi...@apache.org>.
carols10cents commented on pull request #8405:
URL: https://github.com/apache/arrow/pull/8405#issuecomment-707703699
Yup, we can keep this as a draft, no problem! I'll be rebasing and adding to this on Wednesday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org